fix(CoreQueryBuilder): Use correct member entry for circle as initiator #1758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mejo-
force-pushed
the
fix/probe_initiator
branch
7 times, most recently
from
4211fa8 to
5528f13
Compare
Before, the member entry that matched the `singleId` of the user and `level = 9` was used as initiator, which in practice means the member entry for the internal user circle of the user most of the time. Instead, we want to use the member entry that matches `singleId` of the user and `circleId` of the circle in question. This fixes the wrong `level` being set for `initiator` when calling `circleProbe()` with `DataProbe::INITIATOR`. Fixes: #1757 Signed-off-by: Jonas <[email protected]>
Required for testing (where only one php thread is available), but as well for clients that require the event to be excecuted immediately. Signed-off-by: Jonas <[email protected]>
mejo-
force-pushed
the
fix/probe_initiator
branch
from
5528f13 to
70e3ebf
Compare
mejo-
force-pushed
the
fix/probe_initiator
branch
from
70e3ebf to
a8de480
Compare
Signed-off-by: Jonas <[email protected]>
mejo-
force-pushed
the
fix/probe_initiator
branch
from
a8de480 to
8aae043
Compare
|
/backport to stable30 |
|
/backport to stable29 |
|
/backport to stable28 |
4 tasks
ArtificialOwl
approved these changes
Nov 21, 2024
This was referenced Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, the member entry that matched the
singleIdof the user andlevel = 9was used as initiator, which in practice means the member entry for the internal user circle of the user most of the time.Instead, we want to use the member entry that matches
singleIdof the user andcircleIdof the circle in question.This fixes the wrong
levelbeing set forinitiatorwhen callingcircleProbe()withDataProbe::INITIATOR.Fixes: #1757