-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
probeCircles()
with dataProbe
for initiator returns wrong member level.
#1757
Labels
Comments
mejo-
added a commit
that referenced
this issue
Nov 18, 2024
Before, the member entry that matched the `singleId` of the user and `level = 9` was used as initiator, which in practice means the member entry for the internal user circle of the user most of the time. Instead, we want to use the member entry that matches `singleId` of the user and `circleId` of the circle in question. This fixes the wrong `level` being set for `initiator` when calling `circleProbe()` with `DataProbe::INITIATOR`. Fixes: #1757 Signed-off-by: Jonas <[email protected]>
mejo-
added a commit
that referenced
this issue
Nov 19, 2024
Before, the member entry that matched the `singleId` of the user and `level = 9` was used as initiator, which in practice means the member entry for the internal user circle of the user most of the time. Instead, we want to use the member entry that matches `singleId` of the user and `circleId` of the circle in question. This fixes the wrong `level` being set for `initiator` when calling `circleProbe()` with `DataProbe::INITIATOR`. Fixes: #1757 Signed-off-by: Jonas <[email protected]>
mejo-
added a commit
that referenced
this issue
Nov 20, 2024
Before, the member entry that matched the `singleId` of the user and `level = 9` was used as initiator, which in practice means the member entry for the internal user circle of the user most of the time. Instead, we want to use the member entry that matches `singleId` of the user and `circleId` of the circle in question. This fixes the wrong `level` being set for `initiator` when calling `circleProbe()` with `DataProbe::INITIATOR`. Fixes: #1757 Signed-off-by: Jonas <[email protected]>
backportbot bot
pushed a commit
that referenced
this issue
Nov 21, 2024
Before, the member entry that matched the `singleId` of the user and `level = 9` was used as initiator, which in practice means the member entry for the internal user circle of the user most of the time. Instead, we want to use the member entry that matches `singleId` of the user and `circleId` of the circle in question. This fixes the wrong `level` being set for `initiator` when calling `circleProbe()` with `DataProbe::INITIATOR`. Fixes: #1757 Signed-off-by: Jonas <[email protected]>
backportbot bot
pushed a commit
that referenced
this issue
Nov 21, 2024
Before, the member entry that matched the `singleId` of the user and `level = 9` was used as initiator, which in practice means the member entry for the internal user circle of the user most of the time. Instead, we want to use the member entry that matches `singleId` of the user and `circleId` of the circle in question. This fixes the wrong `level` being set for `initiator` when calling `circleProbe()` with `DataProbe::INITIATOR`. Fixes: #1757 Signed-off-by: Jonas <[email protected]>
backportbot bot
pushed a commit
that referenced
this issue
Nov 21, 2024
Before, the member entry that matched the `singleId` of the user and `level = 9` was used as initiator, which in practice means the member entry for the internal user circle of the user most of the time. Instead, we want to use the member entry that matches `singleId` of the user and `circleId` of the circle in question. This fixes the wrong `level` being set for `initiator` when calling `circleProbe()` with `DataProbe::INITIATOR`. Fixes: #1757 Signed-off-by: Jonas <[email protected]>
mejo-
added a commit
that referenced
this issue
Nov 25, 2024
Before, the member entry that matched the `singleId` of the user and `level = 9` was used as initiator, which in practice means the member entry for the internal user circle of the user most of the time. Instead, we want to use the member entry that matches `singleId` of the user and `circleId` of the circle in question. This fixes the wrong `level` being set for `initiator` when calling `circleProbe()` with `DataProbe::INITIATOR`. Fixes: #1757 Signed-off-by: Jonas <[email protected]>
mejo-
added a commit
that referenced
this issue
Nov 25, 2024
Before, the member entry that matched the `singleId` of the user and `level = 9` was used as initiator, which in practice means the member entry for the internal user circle of the user most of the time. Instead, we want to use the member entry that matches `singleId` of the user and `circleId` of the circle in question. This fixes the wrong `level` being set for `initiator` when calling `circleProbe()` with `DataProbe::INITIATOR`. Fixes: #1757 Signed-off-by: Jonas <[email protected]>
mejo-
added a commit
that referenced
this issue
Nov 25, 2024
Before, the member entry that matched the `singleId` of the user and `level = 9` was used as initiator, which in practice means the member entry for the internal user circle of the user most of the time. Instead, we want to use the member entry that matches `singleId` of the user and `circleId` of the circle in question. This fixes the wrong `level` being set for `initiator` when calling `circleProbe()` with `DataProbe::INITIATOR`. Fixes: #1757 Signed-off-by: Jonas <[email protected]>
mejo-
added a commit
that referenced
this issue
Nov 25, 2024
Before, the member entry that matched the `singleId` of the user and `level = 9` was used as initiator, which in practice means the member entry for the internal user circle of the user most of the time. Instead, we want to use the member entry that matches `singleId` of the user and `circleId` of the circle in question. This fixes the wrong `level` being set for `initiator` when calling `circleProbe()` with `DataProbe::INITIATOR`. Fixes: #1757 Signed-off-by: Jonas <[email protected]>
mejo-
added a commit
that referenced
this issue
Nov 25, 2024
Before, the member entry that matched the `singleId` of the user and `level = 9` was used as initiator, which in practice means the member entry for the internal user circle of the user most of the time. Instead, we want to use the member entry that matches `singleId` of the user and `circleId` of the circle in question. This fixes the wrong `level` being set for `initiator` when calling `circleProbe()` with `DataProbe::INITIATOR`. Fixes: #1757 Signed-off-by: Jonas <[email protected]>
mejo-
added a commit
that referenced
this issue
Nov 25, 2024
Before, the member entry that matched the `singleId` of the user and `level = 9` was used as initiator, which in practice means the member entry for the internal user circle of the user most of the time. Instead, we want to use the member entry that matches `singleId` of the user and `circleId` of the circle in question. This fixes the wrong `level` being set for `initiator` when calling `circleProbe()` with `DataProbe::INITIATOR`. Fixes: #1757 Signed-off-by: Jonas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Using
CirclesManager
like in the following code,$level
is always9
(owner), regardless of the real membership level of the initiator:This is because the built SQL query fetches the row from
oc_circles_memberships
that matches thesingleId
of the user andlevel = 9
(which will always be the entry for the internal user circle):The query results in the following for a user who is simple member (not admin/owner!) of only one circle:
See the
b_h_level
field in the result above. It should be4
in this case, not9
!The text was updated successfully, but these errors were encountered: