Disable publishing when Sharing by link is disabled #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tcitworld, thanks for your PR! By analyzing the history of the files in this pull request, we identified @georgehrke, @tomneedham and @raghunayyar to be potential reviewers. |
|
Fixes on server will require more fixes here. |
georgehrke
added
2. developing
|
Will look into the tests asap. |
Signed-off-by: Thomas Citharel <tcit@tcit-pc>
georgehrke
force-pushed
the
disable-public-link-share
branch
from
d79b8b5 to
bfd9bac
Compare
georgehrke
added
3. to review
|
@tcitworld Is there already a corresponding server side pull-request? |
georgehrke
approved these changes
Jul 17, 2017
|
@tcitworld Can you please double-check my changes :) |
These includes for example handling public links when the sharing link feature is disabled, resulting in a 410 server error). |
|
Your changes are valid. :) |
Any update? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #525 on client side.
Please complete the tests, karma is long time no see.