Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to disable public sharing #525

Closed
baltaner opened this issue Jul 2, 2017 · 2 comments
Closed

Option to disable public sharing #525

baltaner opened this issue Jul 2, 2017 · 2 comments
Labels
enhancement New feature request
Milestone
1.5.4-current-mai...

Comments

@baltaner
Copy link

baltaner commented Jul 2, 2017

Steps to reproduce

  1. users are authenticated by ldap
  2. Click on sharing-icon
  3. Checkbox to public sharing appears

Expected behaviour

I disabled "Allow users to share by link" in nextcloud configuration
I enabled "Allow apps to use share-API"

I expect that there is no public sharing possible in calendar-app

Actual behaviour

Public sharing is possible!

Server configuration

Operating system:
ubuntu 16.04
Web server:
apache 2.4
Database:
mysql 5.7.18
PHP version:
7.0.18
Server version: (see your admin page)
12.0.0
Calendar version: (see the apps page)
1.5.3
@georgehrke
Copy link
Member

Please report in the server repo as well
@tcitworld

@tcitworld
Copy link
Member

tcitworld commented Jul 2, 2017 •
edited
Loading

Fix is coming, writing tests...

@tcitworld tcitworld mentioned this issue Jul 2, 2017
Merged
@georgehrke georgehrke added the enhancement New feature request label Jul 5, 2017
@georgehrke georgehrke added this to the 1.6.0-current milestone Jul 5, 2017
pboguslawski added a commit to ibpl/server that referenced this issue Oct 1, 2022
@pboguslawski
Disable sharing calendars via link when sharik via link is disabled
45eefc2 
This mod disallows sharing calendars via link when `shareapi_allow_links`
is disabled.

Related: nextcloud/calendar#525
Related: nextcloud/calendar#4399
Author-Change-Id: IB#1126264
Signed-off-by: Pawel Boguslawski <[email protected]>
@pboguslawski pboguslawski mentioned this issue Oct 1, 2022
Closed
pboguslawski added a commit to ibpl/calendar that referenced this issue Oct 1, 2022
@pboguslawski
Hide sharing calendar via link in UI when sharing via link is disabled
608636d 
This mod hides sharing calendar via link in UI when `shareapi_allow_links` is disabled.
Should be applied together with nextcloud/server#34372

Related: nextcloud/server#34372
Related: nextcloud#525
Related: nextcloud#4399
Author-Change-Id: IB#1126264
Signed-off-by: Pawel Boguslawski <[email protected]>
@pboguslawski pboguslawski mentioned this issue Oct 1, 2022
Closed
tcitworld pushed a commit to nextcloud/server that referenced this issue Oct 28, 2022
@pboguslawski @tcitworld
Disable sharing calendars via link when sharik via link is disabled
588574d 
This mod disallows sharing calendars via link when `shareapi_allow_links`
is disabled.

Related: nextcloud/calendar#525
Related: nextcloud/calendar#4399
Author-Change-Id: IB#1126264
Signed-off-by: Pawel Boguslawski <[email protected]>
tcitworld pushed a commit to nextcloud/server that referenced this issue Jan 20, 2023
@pboguslawski @tcitworld
Disable sharing calendars via link when sharik via link is disabled
f931259 
This mod disallows sharing calendars via link when `shareapi_allow_links`
is disabled.

Related: nextcloud/calendar#525
Related: nextcloud/calendar#4399
Author-Change-Id: IB#1126264
Signed-off-by: Pawel Boguslawski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature request
Projects
None yet
Milestone
1.5.4-current-maintenance
Development

No branches or pull requests
3 participants
@georgehrke @tcitworld @baltaner