Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated avatar handling #7098

Merged
merged 4 commits into from
Nov 18, 2020
Merged

Updated avatar handling #7098

merged 4 commits into from
Nov 18, 2020

Conversation

tobiasKaminsky
Copy link
Member

For: nextcloud/server#23467

Signed-off-by: tobiasKaminsky [email protected]

Testing

Writing tests is very important. Please try to write some tests for your PR.
If you need help, please do not hesitate to ask in this PR for help.

unit tests
instrumented tests
UI tests

  • Tests written, or not not needed

@tobiasKaminsky tobiasKaminsky mentioned this pull request Oct 15, 2020
Open
4 tasks
AndyScherzinger
AndyScherzinger requested changes Oct 15, 2020
View reviewed changes
Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor issue with the license header in the xml file

src/main/res/layout/file_details_share_group.xml Outdated
~
~ You should have received a copy of the GNU Affero General Public License
~ along with this program. If not, see <https://www.gnu.org/licenses/>.
-->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we usually don't prefix license header comment lines with ~

AndyScherzinger
AndyScherzinger approved these changes Oct 15, 2020
View reviewed changes
Copy link
Member

@AndyScherzinger AndyScherzinger left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good but needs a rebase for the code checks to show proper lint result comparisons

ktlint issue should get fixed

@nextcloud-android-bot Codacy Production
Copy link
Collaborator

Codacy Here is an overview of what got changed by this pull request:

Complexity decreasing per file
==============================
+ src/main/java/com/owncloud/android/ui/adapter/OCFileListAdapter.java  -2

See the complete overview on Codacy

@tobiasKaminsky tobiasKaminsky mentioned this pull request Oct 27, 2020
Closed
@Valdnet Valdnet mentioned this pull request Oct 28, 2020
Closed
@tobiasKaminsky @AndyScherzinger
Updated avatar handling
85551b5 
Signed-off-by: tobiasKaminsky <[email protected]>
@AndyScherzinger
update dark screenshots
7807e1e 
Signed-off-by: Andy Scherzinger <[email protected]>
@AndyScherzinger
remove unused resource
aa54d02 
Signed-off-by: Andy Scherzinger <[email protected]>
@AndyScherzinger
no default for share type avatar generation
840d7e5 
Signed-off-by: Andy Scherzinger <[email protected]>
@nextcloud-android-bot
Copy link
Collaborator

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/7098.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Collaborator

Codacy

Lint

TypemasterPR
Warnings307307
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings27
Correctness Warnings53
Internationalization Warnings9
Multithreaded correctness Warnings9
Performance Warnings72
Security Warnings41
Dodgy code Warnings102
Total313

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings27
Correctness Warnings53
Internationalization Warnings9
Multithreaded correctness Warnings9
Performance Warnings72
Security Warnings41
Dodgy code Warnings102
Total313

@nextcloud-android-bot
Copy link
Collaborator

master-light-blue-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/16781-Screenshot-master-light-blue

@nextcloud-android-bot
Copy link
Collaborator

stable-light-blue-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/16781-Screenshot-stable-light-blue

@nextcloud-android-bot
Copy link
Collaborator

stable-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/16781-IT-stable

@nextcloud-android-bot
Copy link
Collaborator

master-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/16781-IT-master

@nextcloud-android-bot
Copy link
Collaborator

master-dark-blue-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/16781-Screenshot-master-dark-blue

@nextcloud-android-bot
Copy link
Collaborator

stable-dark-blue-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/16781-Screenshot-stable-dark-blue

@AndyScherzinger AndyScherzinger merged commit 4de0123 into master Nov 18, 2020
@delete-merged-branch delete-merged-branch bot deleted the avatars branch November 18, 2020 00:07
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.15.0 milestone Nov 18, 2020
thelittlefireman pushed a commit to thelittlefireman/android that referenced this pull request Mar 19, 2021
@AndyScherzinger
Merge pull request nextcloud#7098 from nextcloud/avatars
775cd86 
Updated avatar handling
Signed-off-by: thelittlefireman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
Nextcloud App 3.15.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tobiasKaminsky @nextcloud-android-bot @AndyScherzinger