Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avatar handling #23467

Open
4 tasks
tobiasKaminsky opened this issue Oct 15, 2020 · 8 comments
Open
4 tasks

Avatar handling #23467

tobiasKaminsky opened this issue Oct 15, 2020 · 8 comments
Labels
1. to develop Accepted and waiting to be taken care of client: 💻 desktop client: 🤖🍏 mobile enhancement feature: sharing needs review Needs review to determine if still applicable overview

Comments

@tobiasKaminsky
Copy link
Member

tobiasKaminsky commented Oct 15, 2020

As discussed with @jancborchardt:
image

  • share links:
    • primary background color (currently it is always nc blue)
    • fitting icon color
  • email, others with access, projects, internal link:
    • #ededed as background (always, independent from theming)
    • black icon
  • 1:1 conversation:
    • user avatar
    • fallback: primary background, talk icon
  • group conversation:
    • primary background, talk icon
  • share to group:
    • primary background, multiple user icon
  • federated share:
    • user avatar
    • fallback: 2 initials with computed color
  • circle:
    • #ededed
    • black circle on front, with 1,2, dots to reflect "permission"
    • name (type)
    • icon smaller as like "internal shares"

Grey is "ededed" in light mode with black icon, "#222" in dark mode, with white icon

@tobiasKaminsky
Copy link
Member Author

Currently there is no way to distinguish share to a 1:1 conversation or to a group, right? @nickvergessen

@skjnldsv
Copy link
Member

So server is already like that, right?

@nickvergessen
Copy link
Member

So server is already like that, right?

Well, server does not allow Talk to provide an icon and forces the first letter of whatever the display name is

Currently there is no way to distinguish share to a 1:1 conversation or to a group, right?

Well the room has this info, the question is how an app can provide it the sharing front end or how apps can do things in the sharing to define an icon.

group conversation:

  • primary background, talk icon

It should currently be the public/group icon on grey background like in talk, and in the next versions we will add the option to upload an image for a conversation and in that case it should use that icon

@tobiasKaminsky
Copy link
Member Author

So server is already like that, right?

No: email is primary color, but should be ededed/2222
others with access / internal is wrong background color, should also be ededed/222 with black/white icon

@tobiasKaminsky
Copy link
Member Author

This is current new state on Android:
image

Missing

  • distinguish between types of circle
  • distinguish between 1:1 / group conversation

@tobiasKaminsky
Copy link
Member Author

Update on Android:
image
image

@skjnldsv skjnldsv added 1. to develop Accepted and waiting to be taken care of and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Oct 15, 2020
@tobiasKaminsky
Copy link
Member Author

@jancborchardt for confirmation

@jancborchardt
Copy link
Member

Yep, looks great! :) Nice work

@tobiasKaminsky tobiasKaminsky moved this to 🧭 Planning evaluation (dont pick) in 🤖 🍏 Clients team Aug 18, 2022
@joshtrichards joshtrichards added needs review Needs review to determine if still applicable feature: sharing labels Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of client: 💻 desktop client: 🤖🍏 mobile enhancement feature: sharing needs review Needs review to determine if still applicable overview
Projects
Status: 🧭 Planning evaluation (don't pick)
Development

No branches or pull requests

5 participants