Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mime type info from details screen #1632

Merged
merged 9 commits into from
Oct 24, 2017

Conversation

AndyScherzinger
Copy link
Member

This is described in #1212 - #1212 (comment) to be exact.

Screenshot:
device-2017-10-06-113802

Can be merged for 2.0.0RC9, 2.0.0 final or later since it is just the removal of one info from the view... I'll leave that decision to you @tobiasKaminsky @mario ... imho a "just merge" no-brainer ;)

@AndyScherzinger AndyScherzinger changed the title Removes mime type info from details screen Remove mime type info from details screen Oct 6, 2017
@AndyScherzinger AndyScherzinger force-pushed the removeFileTypeInfoForDetails branch 2 times, most recently from 86dec8c to 81d8112 Compare October 9, 2017 09:58
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, looks better. :) Next up: Moving the size and date under the filename in a second line? ;)

@AndyScherzinger
Copy link
Member Author

Ah, you mean like in the list view?

@comradekingu
Copy link
Contributor

sharevialink

What does it look like when things are shared?

@AndyScherzinger
Copy link
Member Author

@comradekingu
screenshot_20171009-211042

@AndyScherzinger
Copy link
Member Author

Great, looks better. :) Next up: Moving the size and date under the filename in a second line? ;)

@jancborchardt there you go:
device-2017-10-09-225248

device-2017-10-09-225321

@tobiasKaminsky
Copy link
Member

@jancborchardt is this fine for you?
@AndyScherzinger please rebase :-)

@tobiasKaminsky tobiasKaminsky added this to the Nextcloud App 2.1.0 milestone Oct 10, 2017
@jancborchardt
Copy link
Member

@AndyScherzinger aaawesome! :) Much better.
If we can see that there is no preview (only filetype icon) we can also show it smaller, like same size as it would be in the list view.

Otherwise fine - I don't want to keep piling requests into this one change. ;)

@AndyScherzinger AndyScherzinger force-pushed the removeFileTypeInfoForDetails branch from a88f4cd to d8c2593 Compare October 10, 2017 21:52
@AndyScherzinger
Copy link
Member Author

If we can see that there is no preview (only filetype icon) we can also show it smaller, like same size as it would be in the list view.

should be done in another issue/PR and need some more detailing. For example, looking at the screenshots the details screen shows the file name with up to three lines. With the icon in the list view size we could only show one line or make everything aligned-top...

@jancborchardt
Copy link
Member

Alright, sounds good! My 👍 still stands. :)

@tobiasKaminsky
Copy link
Member

@AndyScherzinger can you rebase? 49 changed files seems a little too much ;-)

@AndyScherzinger AndyScherzinger force-pushed the removeFileTypeInfoForDetails branch from d8c2593 to b96037f Compare October 12, 2017 15:51
@AndyScherzinger
Copy link
Member Author

49 changed files seems a little too much

@tobiasKaminsky nope, that is absolutely correct, due to the removal of now unused strings in all string.xml files of all languages (lint check...)

@tobiasKaminsky
Copy link
Member

Ah...Transifex is doing this by itself, but then lint would complain.

@AndyScherzinger
Copy link
Member Author

exactly, a warning per item/language... :/

@AndyScherzinger AndyScherzinger force-pushed the removeFileTypeInfoForDetails branch from b96037f to 73912fe Compare October 18, 2017 11:51
@AndyScherzinger
Copy link
Member Author

pinging @tobiasKaminsky @mario for review :)

@AndyScherzinger AndyScherzinger force-pushed the removeFileTypeInfoForDetails branch from 67b6c89 to d0e015d Compare October 18, 2017 14:15
@mario
Copy link
Contributor

mario commented Oct 18, 2017

👍

Approved with PullApprove

@AndyScherzinger AndyScherzinger force-pushed the removeFileTypeInfoForDetails branch 4 times, most recently from ec4c9d7 to a00dc4c Compare October 19, 2017 20:32
@AndyScherzinger AndyScherzinger force-pushed the removeFileTypeInfoForDetails branch 2 times, most recently from 0c47a29 to 2fc50f1 Compare October 20, 2017 18:23
@tobiasKaminsky
Copy link
Member

tobiasKaminsky commented Oct 24, 2017

👍
(and rebased)

Approved with PullApprove

@tobiasKaminsky tobiasKaminsky force-pushed the removeFileTypeInfoForDetails branch from 2fc50f1 to 8e77e3f Compare October 24, 2017 11:38
@AndyScherzinger AndyScherzinger force-pushed the removeFileTypeInfoForDetails branch from 8e77e3f to 030536a Compare October 24, 2017 12:22
@AndyScherzinger AndyScherzinger merged commit ecb72a0 into master Oct 24, 2017
@AndyScherzinger AndyScherzinger deleted the removeFileTypeInfoForDetails branch October 24, 2017 13:04
@AndyScherzinger
Copy link
Member Author

Merged to master for 2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants