-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove mime type info from details screen #1632
Conversation
86dec8c
to
81d8112
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, looks better. :) Next up: Moving the size and date under the filename in a second line? ;)
Ah, you mean like in the list view? |
@jancborchardt there you go: |
@jancborchardt is this fine for you? |
@AndyScherzinger aaawesome! :) Much better. Otherwise fine - I don't want to keep piling requests into this one change. ;) |
a88f4cd
to
d8c2593
Compare
should be done in another issue/PR and need some more detailing. For example, looking at the screenshots the details screen shows the file name with up to three lines. With the icon in the list view size we could only show one line or make everything aligned-top... |
Alright, sounds good! My 👍 still stands. :) |
@AndyScherzinger can you rebase? 49 changed files seems a little too much ;-) |
d8c2593
to
b96037f
Compare
@tobiasKaminsky nope, that is absolutely correct, due to the removal of now unused strings in all string.xml files of all languages (lint check...) |
Ah...Transifex is doing this by itself, but then lint would complain. |
exactly, a warning per item/language... :/ |
b96037f
to
73912fe
Compare
pinging @tobiasKaminsky @mario for review :) |
67b6c89
to
d0e015d
Compare
ec4c9d7
to
a00dc4c
Compare
0c47a29
to
2fc50f1
Compare
2fc50f1
to
8e77e3f
Compare
8e77e3f
to
030536a
Compare
Merged to master for 2.1 |
This is described in #1212 - #1212 (comment) to be exact.
Screenshot:
Can be merged for 2.0.0RC9, 2.0.0 final or later since it is just the removal of one info from the view... I'll leave that decision to you @tobiasKaminsky @mario ... imho a "just merge" no-brainer ;)