Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamped detail screen, part 2 #1212

Closed
tobiasKaminsky opened this issue Jul 20, 2017 · 7 comments
Closed

Revamped detail screen, part 2 #1212

tobiasKaminsky opened this issue Jul 20, 2017 · 7 comments

Comments

@tobiasKaminsky
Copy link
Member

PR #1156 is a real great UI enhancement.
During review I found new ideas, which we should discuss

  • make shared link clickable -> open up same "sharing link" dialog as in shared dialog
  • click on user opens up detailed sharing option for this user
  • show a "x" to remove an user very fast from the sharees

@AndyScherzinger @jancborchardt

@AndyScherzinger
Copy link
Member

Sounds good to me and would further improve the screen 👍

@jancborchardt
Copy link
Member

show a "x" to remove an user very fast from the sharees

We should do it exactly like the share view on the server, with a dropdown including the available permission options and ability to remove them.

@jancborchardt
Copy link
Member

jancborchardt commented Aug 13, 2017

Right, I have to add: We should merge the Details screen and the Share view, to be exactly like the right sidebar in files. The one view to do everything. Details of the file/folder on top (smaller filetype icon, move technical info to one row) and a tabbed view for »Sharing« and »Activity« (with comments, versions and changes).

Otherwise we duplicate stuff, like where you can unshare and view who it’s shared with. For example in this view it’s confusing that you can not add new people.

@AndyScherzinger
Copy link
Member

Sounds good to me. Questions for clarification:

  • what do you mean by technical info and shouldn't that then be another tab with file info?
  • how do we handle getting to the action(s): right now we have 2 actions "details" and "share", with this change both would navigate to the details screen with the tabs for sharing, activity etc. Is this fine by everyone. Id say if possible we should then keep the menu entries and display the fitting tab (e.g. if share has been chosen the share tab is the active one, not activity or any other).
  • where should we then put the "set available offline" elements

@jancborchardt
Copy link
Member

Technical info: file type (should be removed completely as we have the extension), size, and date.

The top part should basically exactly be like the list view, with favicon/preview, filename right next to it and size and date in one line under the filename

"Details" would go to a to-establish activity/comment/versions tab called "Activity" like in the web interface.
"Sharing would go to the Sharing tab.
Those are the only two tabs (we need to merge activity/comments/versions in the server still …)

Set available offline we could keep where it is, under the header part and above the tabs. Let's discuss at the conf if we want to move it.

@AndyScherzinger
Copy link
Member

PR for mime type removal on file details screen: #1632

@AndyScherzinger
Copy link
Member

closed. successor is: #2485

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants