Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an unordered list for the list of activities #1071

Merged
merged 1 commit into from
Feb 3, 2023
Merged

Create an unordered list for the list of activities #1071

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion css/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
#container h2 {
margin-left: 24px;
margin-bottom: 16px;
}

.section-header {
display: block;
padding: 30px 30px 0 30px;
margin-bottom: 0;
}

.activitysubject {
Expand Down
17 changes: 9 additions & 8 deletions js/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,12 +202,13 @@ $(function(){
}
}

var content = '<div class="section activity-section group" data-date="' + escapeHTML(dayOfYear) + '">' + "\n"
+' <h2 title="' + escapeHTML(dateOfDay) + '">' + escapeHTML(displayDate) + '</h2>' + "\n"
+' <span class="hidden-visually">' + escapeHTML(dateOfDay) + '</span>' + "\n"
+' <div class="boxcontainer">' + "\n"
+' </div>' + "\n"
+'</div>';
var header = '<h2 class="section-header" title="' + escapeHTML(dateOfDay) + '">' + escapeHTML(displayDate) + '</h2>'
+' <span class="hidden-visually">' + escapeHTML(dateOfDay) + '</span>' + "\n";
var content = '<ul class="section activity-section group" data-date="' + escapeHTML(dayOfYear) + '">' + '</ul>';
var $header = $(header);
this.processElements($header);
this.$container.append($header);

var $content = $(content);
this.processElements($content);
this.$container.append($content);
Expand All @@ -231,7 +232,7 @@ $(function(){
var monochromeIcon = activity.type !== 'file_created' && activity.type !== 'file_deleted' && activity.type !== 'favorite' && !activity.icon.endsWith('-color.svg');

var content = ''
+ '<div class="activity box" data-activity-id="' + activity.activity_id + '">' + "\n"
+ '<li class="activity box" data-activity-id="' + activity.activity_id + '">' + "\n"
+ ' <div class="messagecontainer">' + "\n"

+ ' <div class="activity-icon' + ((monochromeIcon) ? ' monochrome' : '') +'">'
Expand Down Expand Up @@ -270,7 +271,7 @@ $(function(){
}

content += ' </div>' + "\n"
+'</div>';
+'</li>';

var $content = $(content);
this.processElements($content);
Expand Down