Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an unordered list for the list of activities #1071

Conversation

JuliaKirschenheuter
Copy link
Contributor

Fixes #1020

Before After
Screenshot from 2023-01-31 11-18-14 Screenshot from 2023-01-31 14-41-45

@nickvergessen
Copy link
Member

That's only half of it.

Files sidebar already uses ul-li:
https://github.com/nextcloud/activity/blob/master/src/views/ActivityTab.vue#L32-L37

@JuliaKirschenheuter
Copy link
Contributor Author

Hi @michaelnissenbaum,

From the last review you mentioned that the content of activities should be a list and not just mixed content. I'm curious if i achieved it. In current case i have a complex content inside, not only some text (please see the screenshots above). Thank you!

@JuliaKirschenheuter
Copy link
Contributor Author

That's only half of it.

Ok, does it mean i should replace it on other places (please write me which ones)? *besides sidebar

@nickvergessen
Copy link
Member

Ok, does it mean i should replace it on other places (please write me which ones)? *besides sidebar

Sidebar is already fixed, and those are the 2 places

@JuliaKirschenheuter
Copy link
Contributor Author

/backport to stable25

@JuliaKirschenheuter JuliaKirschenheuter merged commit 756f881 into master Feb 3, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix/1020-List_of_activities_should_be_marked_up_as_unordered_list branch February 3, 2023 15:05
@backportbot-nextcloud
Copy link

The backport to stable25 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable25
git pull origin/stable25

# Create the new backport branch
git checkout -b fix/foo-stable25

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@michaelnissenbaum
Copy link

Hi @JuliaKirschenheuter the new code looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BITV] List of activities should be marked up as <ul> unordered list with <li> elements
4 participants