-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create an unordered list for the list of activities #1071
Create an unordered list for the list of activities #1071
Conversation
Signed-off-by: julia.kirschenheuter <[email protected]>
Files sidebar already uses ul-li: |
From the last review you mentioned that the content of activities should be a list and not just mixed content. I'm curious if i achieved it. In current case i have a complex content inside, not only some text (please see the screenshots above). Thank you! |
Ok, does it mean i should replace it on other places (please write me which ones)? *besides sidebar |
Sidebar is already fixed, and those are the 2 places |
/backport to stable25 |
The backport to stable25 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable25
git pull origin/stable25
# Create the new backport branch
git checkout -b fix/foo-stable25
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25 More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
Hi @JuliaKirschenheuter the new code looks good to me. |
Fixes #1020