fix(NcRichContenteditable): respect forward slash as user mention character #5323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…racter - during parsing, user mentions wrapped with double quotes (@"[email protected]" or @"space user") handled differently from unwrapped. There are cases mention could contain forward slash character (@"group/talk"), regex should respect that character correctly Signed-off-by: Maksim Sukharev <[email protected]>
Antreesy
added
bug
ShGKme
approved these changes
Feb 28, 2024
DorraJaouad
approved these changes
Feb 28, 2024
|
/backport to next |
3 tasks
| @@ -32,7 +32,7 @@ const MENTION_START = '(?:^|\\s)' | |||
| // Anything that is not text or end-of-line. Non-capturing group | |||
| const MENTION_END = '(?:[^a-z]|$)' | |||
| export const USERID_REGEX = new RegExp(`${MENTION_START}(@[a-zA-Z0-9_.@\\-']+)(${MENTION_END})`, 'gi') | |||
| export const USERID_REGEX_WITH_SPACE = new RegExp(`${MENTION_START}(@"[a-zA-Z0-9 _.@\\-']+")(${MENTION_END})`, 'gi') | |||
| export const USERID_REGEX_WITH_SPACE = new RegExp(`${MENTION_START}(@"[a-zA-Z0-9 _/.@\\-']+")(${MENTION_END})`, 'gi') | |||
There was a problem hiding this comment.
for federation we also need : as the port could be part of the cloudId
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖼️ Screenshots
🏁 Checklist
nextrequested with a Vue 3 upgrade