Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enh(NcRichContenteditable): Add optional visual label for content editable #4907

Merged
merged 2 commits into from
Dec 4, 2023
Merged

enh(NcRichContenteditable): Add optional visual label for content editable #4907

merged 2 commits into from
Dec 4, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Dec 3, 2023

☑️ Resolves

For consistent look of Nextcloud components this adds the same label as NcTextField / NcInputField / NcTextArea.

🖼️ Screenshots

vokoscreenNG-2023-12-03_19-26-38.mp4

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

@susnux susnux added enhancement New feature or request 3. to review Waiting for reviews design Design, UX, interface and interaction design feature: rich-contenteditable Related to the rich-contenteditable components labels Dec 3, 2023
@susnux susnux added this to the 8.4.0 milestone Dec 3, 2023
@susnux
Copy link
Contributor Author

susnux commented Dec 3, 2023

A use case could be: nextcloud/server#41884

@susnux susnux force-pushed the enh/add-visual-label-for-contenteditable branch from 45d5bf0 to 9c8bb46 Compare December 3, 2023 20:38
@susnux susnux requested a review from ShGKme December 3, 2023 20:39
ShGKme

This comment was marked as resolved.

Sign in to view

ShGKme
ShGKme approved these changes Dec 3, 2023
View reviewed changes
Copy link
Contributor

@ShGKme ShGKme left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine. Was broken to me by JetBrains Grazie browser extension...

@susnux susnux merged commit b01bcef into master Dec 4, 2023
14 checks passed
@susnux susnux deleted the enh/add-visual-label-for-contenteditable branch December 4, 2023 12:00
@susnux susnux mentioned this pull request Dec 11, 2023
Closed
@Antreesy
Copy link
Contributor

Note (more for myself, but maybe we should mark it in the changleog): additional <div> wrapper around the input breaks styles, currently applied directly with <NcRichContenteditable class="custom-styling" />

image
Screenshot from 2023-12-14 16-13-19

@ShGKme
Copy link
Contributor

ShGKme commented Dec 14, 2023

Note (more for myself, but maybe we should mark it in the changleog): additional <div> wrapper around the input breaks styles, currently applied directly with <NcRichContenteditable class="custom-styling" />

That is expected (was discussed in the original issue). But formally, it is not a breaking change, because it doesn't change component's public interface and styles in Talk changed internal styles, not positioning styles.

@Antreesy Antreesy mentioned this pull request Dec 21, 2023
Merged
@ShGKme ShGKme mentioned this pull request Dec 22, 2023
Merged
@ShGKme ShGKme mentioned this pull request Mar 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoambrosini marcoambrosini marcoambrosini approved these changes

@ShGKme ShGKme ShGKme approved these changes

@st3iny st3iny Awaiting requested review from st3iny

@Pytal Pytal Awaiting requested review from Pytal

@szaimen szaimen Awaiting requested review from szaimen

Assignees
No one assigned
Labels
3. to review Waiting for reviews design Design, UX, interface and interaction design enhancement New feature or request feature: rich-contenteditable Related to the rich-contenteditable components
Projects
None yet
Milestone
8.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@susnux @Antreesy @ShGKme @marcoambrosini