[BITV] 9.3.3.2/3.1 - Comment section: The input fields for creating and editing comments lack visual labels. (2)

[JuliaKirschenheuter]

https://report.bitvtest.de/default-en/cbedb5ef-4815-4cba-a83d-995599c178c3.html#checkpoint-9f92015c98-v3-n1

9.3.3.2/11.1 - https://report.bitvtest.de/default-en/cbedb5ef-4815-4cba-a83d-995599c178c3.html#checkpoint-9f92015c98-v11-n1

[ShGKme]

There was a suggestion to add the same label as in text fields: #37087 (comment)

However, adding such a label to NcRichcontenteditable would be kind of a "hidden" breaking change and used only here.

What about removing the user avatar here and "Add a comment" label outside here?

[susnux]

There was a suggestion to add the same label as in text fields: #37087 (comment)

I agree on this we should provide the same style of labels for all input elements, NcRichcontent... NcSelect..., like already did with NcTextarea, to have a consistent UI (from a design perspective). But that is out of scope of this issue.

However, adding such a label to NcRichcontenteditable would be kind of a "hidden" breaking change and used only here.

Why would it be a breaking change? For me it would be a feature that is disabled by default..

What about removing the user avatar here and "Add a comment" label outside here?

This would be a breaking design change an make it inconsistent with any other activity.

[ShGKme]

Why would it be a breaking change? For me it would be a feature that is disabled by default..

Currently NcRichContenteditable node is directly a div[contenteditable] node. To add this label, we need to change it by adding a wrapper element. It is not formally a breaking change, but it may break style overriding and direct usage with a template ref.

This would be a breaking design change an make it inconsistent with any other activity.

Adding a label is also a visible change.

But what do you mean by other activity? Is it about activities listed in this tab? If that is, should it be consistent? A form is not an activity.

[susnux]

But what do you mean by other activity? Is it about activities listed in this tab? If that is, should it be consistent? A form is not an activity.

Yes consider clicking edit on the comment, the expected behavior would be to change the comment to the editable version while keeping all other elements.

[...] direct usage with a template ref.

That depends on what you are doing with it using the ref directly is pretty dangerous anyways as you then depend on the implementation details. Meaning if we want any methods to be exposed we should use expose and document them. For example if you need to access the inner contenteditable we could document and expose the ref to contenteditable of the component.

[ShGKme]

Yes consider clicking edit on the comment, the expected behavior would be to change the comment to the editable version while keeping all other elements.

You are correct, I missed that.

[susnux]

Waiting for release of nextcloud-libraries/nextcloud-vue#4907