Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcRichContenteditable): make the default placeholder short #4408

Merged
merged 1 commit into from
Sep 7, 2023
Merged

fix(NcRichContenteditable): make the default placeholder short #4408

merged 1 commit into from
Sep 7, 2023

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Aug 9, 2023 •
edited
Loading

☑️ Resolves

The default placeholder is very long, because it is not a placeholder, but a description with instructions of using the input.

This PR proposes to remove the instruction from the default placeholder.

In case of merging this PR we need to find a way to explain users what they can do with the input at least with user documentation.

See discussion in the issue.

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🚧 Tasks

  • Make the default placeholder short

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

@ShGKme ShGKme mentioned this pull request Aug 9, 2023
Closed
1 task
@ShGKme ShGKme force-pushed the fix/richcontenteditable-placeholder-overflow branch from 439988f to c6201f3 Compare August 30, 2023 09:53
@ShGKme ShGKme self-assigned this Aug 30, 2023
@ShGKme ShGKme added enhancement New feature or request 2. developing Work in progress feature: rich-contenteditable Related to the rich-contenteditable components bug Something isn't working and removed enhancement New feature or request labels Aug 30, 2023
@ShGKme ShGKme added this to the 8.0.0 milestone Aug 30, 2023
@ShGKme ShGKme requested a review from marcoambrosini August 30, 2023 10:09
@ShGKme ShGKme mentioned this pull request Sep 6, 2023
Merged
10 tasks
@ShGKme ShGKme force-pushed the fix/richcontenteditable-placeholder-overflow branch from c6201f3 to b1b486f Compare September 6, 2023 14:04
@ShGKme ShGKme marked this pull request as ready for review September 6, 2023 14:04
@ShGKme ShGKme added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 7, 2023
@ShGKme ShGKme merged commit 704a6cd into master Sep 7, 2023
17 checks passed
@ShGKme ShGKme deleted the fix/richcontenteditable-placeholder-overflow branch September 7, 2023 15:39
@Antreesy Antreesy mentioned this pull request Sep 14, 2023
Merged
@Pytal Pytal mentioned this pull request Sep 15, 2023
Merged
@Antreesy Antreesy mentioned this pull request Sep 15, 2023
Merged
@XueSheng-GIT XueSheng-GIT mentioned this pull request Sep 27, 2023
Closed
8 tasks
@ShGKme ShGKme mentioned this pull request Oct 7, 2023
Closed
@solracsf solracsf mentioned this pull request Oct 15, 2023
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pytal Pytal Pytal approved these changes

@GretaD GretaD GretaD approved these changes

@artonge artonge artonge approved these changes

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@susnux susnux Awaiting requested review from susnux

@raimund-schluessler raimund-schluessler Awaiting requested review from raimund-schluessler

Assignees

@ShGKme ShGKme

Labels
3. to review Waiting for reviews bug Something isn't working feature: rich-contenteditable Related to the rich-contenteditable components
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ShGKme @artonge @GretaD @Pytal