Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable7] - backport for Rich components changes #4526

Merged
merged 13 commits into from
Sep 16, 2023
Merged

[stable7] - backport for Rich components changes #4526

merged 13 commits into from
Sep 16, 2023

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Sep 14, 2023 •
edited
Loading

Backport of following PRs:

Current difference for rich components with master:

Antreesy and others added 12 commits September 14, 2023 17:52
@Antreesy
chore(deps) replace legacy dependency with 'rehype-external-links'
9fbc087 
Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy
chore(RichText) replace legacy dependency with 'rehype-external-links'
9be8794 
Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy
fix(NcAvatar) force white-space wrapping if show initials
a580e3a 
Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy
fix(placeholder) - don't wrap each element in span
ef77bd0 
Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy
fix(NcRichText) revert forced newlines, add base styling for markdown
9d810ea 
Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy
fix(NcRichText) escape XML-like content before markdown parsing
c3691dc 
Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy
feat(docs) show mentions in NcRichText output example
2274027 
Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy
feat(docs) add some markdown examples to the NcRichText docs
42aab3d 
Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy
feat(docs) add cross-example with NcRichContenteditable the NcRichTex…
3e305bb 
…t docs

Signed-off-by: Maksim Sukharev <[email protected]>
@susnux @Antreesy
fix: Fix missing language for scss style
9619518 
Signed-off-by: Ferdinand Thiessen <[email protected]>
(cherry picked from commit a4ffb28)
@ShGKme @Antreesy
fix(NcRichContenteditable): add aria-placeholder
b2540f3 
Signed-off-by: Grigorii K. Shartsev <[email protected]>
@ShGKme @Antreesy
fix(NcRichContenteditable): make the default placeholder short withou…
187926e 
…t instructions

Signed-off-by: Grigorii K. Shartsev <[email protected]>
@Antreesy Antreesy added bug Something isn't working 3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities feature: rich-contenteditable Related to the rich-contenteditable components feature: richtext Related to the richtext component labels Sep 14, 2023
@Antreesy Antreesy added this to the 7.12.5 milestone Sep 14, 2023
@Antreesy Antreesy self-assigned this Sep 14, 2023
@Antreesy Antreesy requested a review from ShGKme September 14, 2023 16:59
@susnux @Antreesy
fix the mixin to allow @ within userids
03ea8bc 
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy Antreesy marked this pull request as ready for review September 15, 2023 07:36
@Antreesy Antreesy requested a review from susnux September 15, 2023 07:36
@Antreesy Antreesy mentioned this pull request Sep 15, 2023
Merged
@nickvergessen nickvergessen merged commit dd642dc into stable7 Sep 16, 2023
15 checks passed
@nickvergessen nickvergessen deleted the backport/4486-4507/stable7 branch September 16, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@ShGKme ShGKme Awaiting requested review from ShGKme

@susnux susnux Awaiting requested review from susnux

@DorraJaouad DorraJaouad Awaiting requested review from DorraJaouad

Assignees

@Antreesy Antreesy

Labels
3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities bug Something isn't working feature: rich-contenteditable Related to the rich-contenteditable components feature: richtext Related to the richtext component
Projects
None yet
Milestone
7.12.5
Development

Successfully merging this pull request may close these issues.
4 participants
@Antreesy @nickvergessen @susnux @ShGKme