-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade project metadata for catalog #33
Merged
danielgolden
merged 6 commits into
newrelic:master
from
danielgolden:feat/upgrade-metadata-for-catalog
Mar 31, 2020
Merged
feat: upgrade project metadata for catalog #33
danielgolden
merged 6 commits into
newrelic:master
from
danielgolden:feat/upgrade-metadata-for-catalog
Mar 31, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbeveland27
approved these changes
Mar 31, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some suggested edits. I think once those are addressed you can merge away 👍
The old tagline was a bit too long and would fail validation (max is 30 character). Co-Authored-By: Justin Eveland <[email protected]>
It would fail validation as the catalog doesn't support images in the documentation.md Co-Authored-By: Justin Eveland <[email protected]>
Co-Authored-By: Justin Eveland <[email protected]>
Co-Authored-By: Justin Eveland <[email protected]>
Because images don't render in the catalog
devfreddy
pushed a commit
that referenced
this pull request
Apr 17, 2020
# [0.4.0](v0.3.2...v0.4.0) (2020-04-17) ### Bug Fixes * linting issues. ([b054f7b](b054f7b)) * remove another image from the documentation ([de371e3](de371e3)) * remove contributors from documentation ([55b30ea](55b30ea)) * remove image from documentation.md ([335fa96](335fa96)) * remove images from catalog documentation ([07f3254](07f3254)) * Styles for when there are more than 4 rows ([7f7678b](7f7678b)), closes [#26](https://github.com/newrelic/issues/26) * upgrade eslint closes newrelic/nr1-customer-journey[#28](#28) ([2e0802d](2e0802d)) ### Features * remove moment, add nr1-community, closes newrelic/nr1-customer-journey[#24](#24) ([ccd0421](ccd0421)) * upgrade project metadata for catalog ([25388bb](25388bb)), closes [#25](https://github.com/newrelic/issues/25) * upgrade project metadata for catalog ([#33](#33)) ([3f2cfc4](3f2cfc4)), closes [#25](https://github.com/newrelic/issues/25)
🎉 This PR is included in version 0.4.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade the project meta data to support new catalog commands
The NR1 CLI will soon be updated with commands that enable one to request to have their app added to the catalog. In order to prepare the existing open source NR1 apps for that coming change I've added meta data according to what the catalog commands will be looking for.
config.json
file to acatalog
directory in the repo root, matching this format./screenshots
directory intocatalog
:README.md
.additionalInfo.md
file to acatalog
directory in the repo root, matching this format.documentation.md
to be absolute pathsREADME.md
andcatalog/documentation.md
.README.md
commands section matches Justin's snippet.npm start
and let the CLI move thenr1.json
Resolves #25