Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When you have any more than 4 steps in your journey, the rows don't match up #26

Closed
danielgolden opened this issue Mar 4, 2020 · 1 comment · Fixed by #29
Closed

When you have any more than 4 steps in your journey, the rows don't match up #26

danielgolden opened this issue Mar 4, 2020 · 1 comment · Fixed by #29
Assignees
@danielgolden
Labels
bug Something isn't working released

Comments

@danielgolden
Copy link
Contributor

danielgolden commented Mar 4, 2020 •
edited
Loading

Description

When you have more that 4 steps in your customer journey, the left column of the nerdpack remains the same height as if it had 4, but the height of the other columns increases to fit actual number of steps.

Captura de Pantalla 2020-03-04 a la(s) 12 25 25 p  m

Steps to Reproduce

  1. Open journeyConfig.js in a code editor
  2. Add an extra object to the steps array

Expected Behavior

What should happen is that the height of the left column should grow, just like the height of the other columns grows so that all of the rows across all of the columns should be aligned.

Potential solution

This is a bit of a hack but until we find the time to properly fix this it will do imo: Create classes which you can apply to the left column depending how many rows there are (maybe just 3 or 4).

Your Environment

  • NR1 CLI version used: @datanerd/nr1/1.19.5 darwin-x64 node-v10.16.3
  • Browser name and version: Chrome 80.0.3987.122 (Build oficial) (64 bits)
  • Operating System and version: MacOS Catalina 10.15.3 (19D76)

Extra context

Here's an example if you have access to our internal Slack workspace: https://newrelic.slack.com/archives/CS537HN3A/p1581690341132400
@danielgolden danielgolden added the bug Something isn't working label Mar 4, 2020
@danielgolden danielgolden pinned this issue Mar 4, 2020
@danielgolden danielgolden changed the title When you have any more than 4 steps in your journey, the rows down match up When you have any more than 4 steps in your journey, the rows don't match up Mar 4, 2020
@danielgolden danielgolden mentioned this issue Mar 26, 2020
Merged
@danielgolden danielgolden self-assigned this Mar 26, 2020
devfreddy pushed a commit that referenced this issue Apr 17, 2020
chore(release): 0.4.0 [skip ci]
e2110a4 
# [0.4.0](v0.3.2...v0.4.0) (2020-04-17)

### Bug Fixes

* linting issues. ([b054f7b](b054f7b))
* remove another image from the documentation ([de371e3](de371e3))
* remove contributors from documentation ([55b30ea](55b30ea))
* remove image from documentation.md ([335fa96](335fa96))
* remove images from catalog documentation ([07f3254](07f3254))
* Styles for when there are more than 4 rows ([7f7678b](7f7678b)), closes [#26](https://github.com/newrelic/issues/26)
* upgrade eslint closes newrelic/nr1-customer-journey[#28](#28) ([2e0802d](2e0802d))

### Features

* remove moment, add nr1-community, closes newrelic/nr1-customer-journey[#24](#24) ([ccd0421](ccd0421))
* upgrade project metadata for catalog ([25388bb](25388bb)), closes [#25](https://github.com/newrelic/issues/25)
* upgrade project metadata for catalog ([#33](#33)) ([3f2cfc4](3f2cfc4)), closes [#25](https://github.com/newrelic/issues/25)
@devfreddy
Copy link
Contributor

🎉 This issue has been resolved in version 0.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@tangollama tangollama unpinned this issue Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielgolden danielgolden

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Styles for when there are more than 4 rows
2 participants
@devfreddy @danielgolden