Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Lock down Rack for old Grape v1.x versions #2711

Merged
merged 5 commits into from
Jun 13, 2024
Merged

CI: Lock down Rack for old Grape v1.x versions #2711

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e28a6bf
CI: Lock down Rack for Grape's benefit
fallwith Jun 12, 2024
9cf146a
CI: only Grape v1.x needs an older Rack
fallwith Jun 13, 2024
78edeb9
start_with -> start_with? typo fix
fallwith Jun 13, 2024
7b41adc
CI: fix grape/rack version combo logic
fallwith Jun 13, 2024
c4f0236
CI: further relax the Grape content-length check
fallwith Jun 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion test/multiverse/suites/grape/Envfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,12 @@ def activesupport_version(grape_version)
end

def gem_list(grape_version = nil)
# TODO: Grape <= v2.0 seems incompatible with Rack v3.1.0+ owing to the fact
# that Grape expects Rack to deliver `rack/auth/digest/md5` and Rack
# no longer offers that class. We should be able to constrain Rack for
# only certain Grape versions once a Grape fix is in place.
<<~RB
gem 'rack'
gem 'rack', '~> 3.0.11'
gem 'rack-test', '>= 0.8.0'
gem 'grape'#{grape_version}

Expand Down
Loading