CI: Lock down Rack for old Grape v1.x versions #2711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grape is unhappy with the new Rack version. Let's lock down Rack in Grape testing contexts until a Grape fix is out.
fallwith
requested review from
hannahramadan,
kaylareopelle and
tannalynn
as code owners
hannahramadan
approved these changes
Jun 13, 2024
it should be fine to use the latest Rack version with Grape v2+
fallwith
changed the title
correct method name
the `starts_with?` check for the grape version string needs to strip away any Bundler version locking prefix
relax the Rack driven content-length check for Grape
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grape v1.x versions unhappy with the new Rack version. Let's lock down Rack when testing those versions.