Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify method namespace #2167

Merged
merged 3 commits into from
Aug 16, 2023
Merged

Specify method namespace #2167

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
add6965
Specify method namespace
hannahramadan Aug 16, 2023
af7ec57
Merge branch 'dev' into roda_namespace_fix
hannahramadan Aug 16, 2023
bd4b537
Update CHANGELOG.md
hannahramadan Aug 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
# New Relic Ruby Agent Release Notes

## v9.4.1

Version 9.4.1 of the agent resolves a `NoMethodError` introduced in 9.4.0.

- **Bugfix: Resolve NoMethodError**

Ruby agent 9.4.0 introduced [Roda instrumentation](https://github.com/newrelic/newrelic-ruby-agent/pull/2144), which caused a `NoMethodError` to be raised when attempting to name a Roda transaction. This has been fixed.

## v9.4.0

Version 9.4.0 of the agent adds [Roda](https://roda.jeremyevans.net/) instrumentation, adds a new `allow_all_headers` configuration option to permit capturing all HTTP headers, introduces improved error tracking functionality by associating a transaction id with each error, and uses more reliable network timeout logic.
Expand Down
2 changes: 1 addition & 1 deletion lib/new_relic/agent/instrumentation/roda/instrumentation.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ def rack_request_params
def _roda_handle_main_route_with_tracing(*args)
perform_action_with_newrelic_trace(
category: :roda,
name: TransactionNamer.transaction_name(request),
name: ::NewRelic::Agent::Instrumentation::Roda::TransactionNamer.transaction_name(request),
params: ::NewRelic::Agent::ParameterFiltering::apply_filters(request.env, rack_request_params)
) do
yield
Expand Down