Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify method namespace #2167

Merged
merged 3 commits into from
Aug 16, 2023
Merged

Specify method namespace #2167

merged 3 commits into from
Aug 16, 2023

Conversation

hannahramadan
Copy link
Contributor

Add full namespace path for method needed to name a Roda transaction

Before contributing, please read our contributing guidelines and code of conduct.

Overview

Describe the changes present in the pull request

Submitter Checklist:

  • Include a link to the related GitHub issue, if applicable
  • Include a security review link, if applicable

Testing

The agent includes a suite of unit and functional tests which should be used to
verify your changes don't break existing functionality. These tests will run with
GitHub Actions when a pull request is made. More details on running the tests locally can be found
here for our unit tests,
and here for our functional tests.
For most contributions it is strongly recommended to add additional tests which
exercise your changes.

Reviewer Checklist

  • Perform code review
  • Add performance label
  • Perform appropriate level of performance testing
  • Confirm all checks passed
  • Add version label prior to acceptance

hannahramadan and others added 2 commits August 16, 2023 08:36
Add full namespace path for method needed to name a Roda transaction
@hannahramadan hannahramadan marked this pull request as ready for review August 16, 2023 15:56
fallwith
fallwith previously approved these changes Aug 16, 2023
@hannahramadan hannahramadan merged commit 4aacb86 into dev Aug 16, 2023
@hannahramadan hannahramadan deleted the roda_namespace_fix branch August 16, 2023 16:32
@github-actions
Copy link
Contributor

SimpleCov Report

Coverage Threshold
Line 94.29% 94%
Branch 85.77% 85%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants