Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip errored Sidekiq/Redis test for Ruby 3.1 #1891

Merged
merged 2 commits into from
Mar 16, 2023
Merged

Skip errored Sidekiq/Redis test for Ruby 3.1 #1891

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
130c3e4
Skip Sidekiq/RedisClient test for Ruby 3.1
kaylareopelle Mar 16, 2023
46f7511
Return clause skip unless sidekiq_without_redis?
kaylareopelle Mar 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions test/multiverse/suites/sidekiq/sidekiq_with_redis_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ class SidekiqWithRedisTest < MiniTest::Test
# NOTE: Because Sidekiq v7.0+ can use `redis-client` without `redis`, this
# test brings in the `redis` gem directly via `bundler/inline`
def test_redis_client_pipelined_calls_work
skip 'The CI fails when trying to run this test because of a Bundler error' if RUBY_VERSION.match?(/^3\.1/)
skip 'Testing conducted only using Sidekiq v7.0+ with redis not yet bundled' unless sidekiq_without_redis?

gemfile do
Expand Down