Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip errored Sidekiq/Redis test for Ruby 3.1 #1891

Merged
merged 2 commits into from
Mar 16, 2023
Merged

Skip errored Sidekiq/Redis test for Ruby 3.1 #1891

merged 2 commits into from
Mar 16, 2023

Conversation

kaylareopelle
Copy link
Contributor

@kaylareopelle kaylareopelle commented Mar 16, 2023 •
edited
Loading

The error showed up on the CI last night for only Ruby 3.1

SidekiqWithRedisTest#test_redis_client_pipelined_calls_work:
Bundler::InstallError: Bundler::DirectoryRemovalError: Could not delete previous installation of `/opt/hostedtoolcache/Ruby/3.1.3/x64/lib/ruby/gems/3.1.0/gems/redis-5.0.6`.
The underlying error was ArgumentError: parent directory is world writable, Bundler::FileUtils#remove_entry_secure does not work

This PR skips the test for Ruby 3.1

There's a separate issue to fix the error: #1894

@kaylareopelle kaylareopelle changed the title try to find out what error to rescue Disable errored test Mar 16, 2023
@kaylareopelle kaylareopelle force-pushed the ci-failure-sidekiq-redis branch from 43ccc31 to 360dde9 Compare March 16, 2023 21:51
@kaylareopelle kaylareopelle changed the title Disable errored test Skip errored test Mar 16, 2023
@kaylareopelle kaylareopelle changed the title Skip errored test Skip errored Sidekiq/Redis test for Ruby 3.1 Mar 16, 2023
@kaylareopelle kaylareopelle force-pushed the ci-failure-sidekiq-redis branch from a538424 to db3a554 Compare March 16, 2023 22:17
@kaylareopelle
Skip Sidekiq/RedisClient test for Ruby 3.1
130c3e4 
The CI fails when running this test on Ruby 3.1 due to a Bundler
error.
@kaylareopelle kaylareopelle force-pushed the ci-failure-sidekiq-redis branch from db3a554 to 130c3e4 Compare March 16, 2023 22:19
tannalynn
tannalynn previously approved these changes Mar 16, 2023
View reviewed changes
@kaylareopelle
Return clause skip unless sidekiq_without_redis?
46f7511 
This is needed so the versions still running this test can work
@kaylareopelle kaylareopelle merged commit 5dbc20c into dev Mar 16, 2023
@kaylareopelle kaylareopelle deleted the ci-failure-sidekiq-redis branch March 16, 2023 22:38
@github-actions
Copy link
Contributor

SimpleCov Report

Coverage Threshold
Line 93.99% 93%
Branch 85.44% 85%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fallwith fallwith fallwith approved these changes

@tannalynn tannalynn tannalynn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaylareopelle @fallwith @tannalynn