-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
errors inbox fingerprinting #1858
Conversation
Allow the customer to register a proc to be invoked on each noticed error in order to associate each noticed error with an error group
remove comment placeholder (since satisfied)
- in the (potentially customer facing) log message, give the class and method name for the public API method producing the message - typo fix ("GRUP" -> "GROUP") in a constant name
- added tests - added getter for the error group callback
- fix pre-existing bug with request.uri applying - make sure internal errors are routed through the error group callback
- revert fix for request.uri setting (to be addressed with a separate PR) - update comment for request.uri setting to have it apply also to error group setting - restore logic to use the caller location as a backtrace (calling `#backtrace` on a noticed error will always return either a trace or a string, but never `nil`).
also include the error group in the agent attributes hash when it is available
add supportability reporting for `set_error_group_callback`
CHANGELOG entries for error fingerprinting and user tracking
@fallwith - Is this still part of the PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't had a chance to think through the tests yet, but will get back to those on Monday!
set_error_group_callback typo Co-authored-by: Kayla Reopelle (she/her) <[email protected]>
Good call. We landed on a decision around that bit of code in separate PR #1871. Removed the entry from this PR's description, thank you. |
SimpleCov Report
|
Allow the customer to register a proc to be invoked on each noticed error in order to associate each noticed error with an error group
Changes made:
set_error_group_callback
API method exists. It must be given a Ruby proc or lambda (must be of typeProc
)error.group.name
.resolves #1845