-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a new set_error_group_callback public API and set a new error_group agent attribute #1845
Milestone
Comments
fallwith
added this to the Errors Inbox - Customer supplied error group setting (fingerprinting) and user tracking milestone
Feb 28, 2023
fallwith
changed the title
Create a new error_group_callback public API and set a new error_group agent attribute
Create a new set_error_group_callback public API and set a new error_group agent attribute
Feb 28, 2023
Hey team! Please add your planning poker estimate with Zenhub @hannahramadan @kaylareopelle @tannalynn |
This is expected to be called once and only once right after the agent initializes |
Add method tracer accepts a stabby lambda/proc as an argument: https://rubydoc.info/gems/newrelic_rpm/NewRelic%2FAgent%2FMethodTracer%2FClassMethods:add_method_tracer |
Addressed by #1858 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A new public
set_error_group_callback
API endpoint must be created in adherence with theAPIs/error_group.md
internal specifications doc.The API must accept as its only argument an instance of a Ruby
Proc
which can be either a proc or lambda but will be referred to generically here as a proc.The proc itself must accept as argument(s) - the exception class instance for a noticed error and as much other information the agent has at notice time such as the transaction name, the transaction user attributes, any web app info such as request URI, response code, and status, etc. It must return exactly one string value: the desired error group to associate the error with. See the
APIs/error_group.md
internal specifications doc for a full list of ideal inputs.When the Ruby agent notices an error, it will check to see if it has an error group callback proc that was supplied by the customer. If so, it will invoke that callback with the error instance and expect to get back either a non empty string, a
nil
, or an empty string. If the agent receives anil
or an empty string, it discards these and takes no new action compared to what it currently does to process the noticed error. If the agent receives a non empty string, it will use the string as the value for a newerror_group
agent attribute that is sent up within the agent attributes hash for the noticed error.The text was updated successfully, but these errors were encountered: