Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End-to-end testing for errors inbox fingerprinting and user tracking #1850

Closed
fallwith opened this issue Mar 1, 2023 · 7 comments
Closed
Assignees

Comments

@fallwith
Copy link
Contributor

fallwith commented Mar 1, 2023

Once issues #1845 and #1847 are complete, a build of the agent should exist that will transmit new error group and user id agent attributes to the errors inbox hosted server-side.

In addition to the unit tests delivered by those stories to confirm that the attributes are always present and formatted correctly when they should be, we ought to conduct some end-to-end testing with an instance of the errors inbox that will respond to the presence of the attributes.

We'll likely just use Ruby agent playground testing, but it'd be neat to see if we could come up with something more automated. We already test with dynamic app names to guarantee we're the only ones using an app at one time. We could potentially fire off errors to the backend and then pause for a short while and then automatically fire off of NRQL query to confirm that the expected behavior has taken place. We haven't done much of that to my knowledge outside of OATS where we do something similar to produce graphs. We typically just use a browser logged in to the staging environment and manually confirm things.

Ultimately the testing - however automated - needs to confirm the following:

  • A noticed error is grouped as desired
  • A noticed error has a user id associated with it
@workato-integration
Copy link

@kaylareopelle
Copy link
Contributor

The errors galore playground in the Rails 6 directory has a good foundation for this work.

@fallwith
Copy link
Contributor Author

fallwith commented Mar 4, 2023

Hey team! Please add your planning poker estimate with Zenhub @hannahramadan @kaylareopelle @tannalynn

@kaylareopelle
Copy link
Contributor

Could also use our audit logs to make sure we're sending data to the right place

@fallwith
Copy link
Contributor Author

fallwith commented Mar 7, 2023

The spec calls for "traced errors" and "error events" to both involve the callback, so we ought to test with both of those.

@fallwith
Copy link
Contributor Author

The spec calls for "traced errors" and "error events" to both involve the callback, so we ought to test with both of those.

This part can be ignored for this story. It has been well handled by the unit tests.

@workato-integration
Copy link

Work has been completed on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

4 participants