Infinite Tracing: batching and compression #1723
Conversation
* reimplement gRPC compression, now that we understand that the `minimal_stack` configuration setting will disable all compression * enable 'high' compression by default * enable batching by default * make the compression level and batching toggle publicly configurable
the binding.pry instances were removed, but the 'require' was left behind
debugging cleanup
| COMPRESSION_LEVELS = %i[none low medium high].freeze | ||
| DEFAULT_COMPRESSION_LEVEL = :none | ||
| SETTINGS_BASE = {'grpc.enable_deadline_checking' => 0}.freeze | ||
| SETTINGS_COMPRESSION_DISABLED = SETTINGS_BASE.merge({'grpc.minimal_stack' => 1}).freeze |
There was a problem hiding this comment.
Most of the content removed from this channel.rb file was simply moved to config.rb, as it is more appropriate to be considered configuration related.
Before this PR, everyone got both enable_deadline_checking' => 0 and minimal_stack' => 1. Now minimal_stack => 1 is not used when compression is desired, as we have learned it will disable compression.
| 'grpc-encoding' => 'gzip', | ||
| 'grpc-accept-encoding' => ['gzip'], | ||
| 'content-coding' => 'gzip', | ||
| 'content-encoding' => 'gzip'}.freeze |
There was a problem hiding this comment.
To align with our gist, use gzip specific metadata.
| :type => Symbol, | ||
| :allowed_from_server => false, | ||
| :external => :infinite_tracing, | ||
| :description => "Configure the compression level for data sent to the Trace Observer\nMay be one of " \ | ||
| "[none|low|medium|high]\nBy default, compression is not used (level = none)" | ||
| "[none|low|medium|high]\n'high' is the default. Set the level to 'none' to disable compression" |
There was a problem hiding this comment.
Make the settings public, and with the first public offering have the defaults be compression high, batching enabled. (See SWAG doc for details)
| @@ -67,6 +67,10 @@ def filter_file | |||
| opts.fetch(:file, nil) | |||
| end | |||
|
|
|||
| def infinite_tracing_suite? | |||
| suite == 'infinite_tracing' | |||
| end | |||
There was a problem hiding this comment.
For this file, I wanted to be able to able to perform:
bundle exec rake test:multiverse[infinite_tracing,file=config_test,debug] but it was incorrectly scoping my config_test file filter to the test/multiverse/suites/infinite_tracing directory. Now using file= will work as desired for 8T tests.
Whoops, Tanna beat me to it! |
reference PR 1723
Sure thing. Added with bdf91aa |
SimpleCov Report
|
minimal_stackconfiguration setting will disable all compression