Update Realtime Profiling Instance Naming #256
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtduffy
approved these changes
Jun 6, 2024
| assertEquals("test_app_name", attributes.asMap().get(SERVICE_NAME)); | ||
| assertEquals("test_app_name", attributes.asMap().get(APP_NAME)); | ||
| assertEquals("test_hostname", attributes.asMap().get(HOSTNAME)); | ||
| assertEquals("test_app_name", attributes.asMap().get(APP_NAME)); |
There was a problem hiding this comment.
Looks to be a dup of the asserts above (APP_NAME and SERVICE_NAME checks)
| assertEquals("test_app_name", attributes.asMap().get(SERVICE_NAME)); | ||
| assertEquals("test_app_name", attributes.asMap().get(APP_NAME)); | ||
| assertEquals("resolved_hostname", attributes.asMap().get(HOSTNAME)); | ||
| assertEquals("test_app_name", attributes.asMap().get(APP_NAME)); |
| assertEquals("test_app_name", attributes.asMap().get(SERVICE_NAME)); | ||
| assertEquals("test_app_name", attributes.asMap().get(APP_NAME)); | ||
| assertEquals(loopbackAddress.toString(), attributes.asMap().get(HOSTNAME)); | ||
| assertEquals("test_app_name", attributes.asMap().get(APP_NAME)); |
| hostname = InetAddress.getLocalHost().toString(); | ||
| } catch (Throwable e) { | ||
| hostname = InetAddress.getLoopbackAddress().toString(); | ||
| if (config.getHostname() == null) { |
There was a problem hiding this comment.
Not sure about having hostname as a config. Probably be good to get other opinions on it.
There was a problem hiding this comment.
Looking back, there is no real need to update the config. This value can be accessed and added to the commonAttributes from the Agent, without changing the config at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Issue #1864