Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct multiple traceparent header logging #2154

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Conversation

jtduffy
Copy link
Contributor

@jtduffy jtduffy commented Nov 22, 2024

Resolves #2126

Based on the logic in method and the associated comment, multiple TraceParent headers is only an issue if the headers differ. If all the headers are the same value, that's ok.

This moves the log statement and associated supportability metric to execute only if the headers are different values.

@jtduffy jtduffy self-assigned this Nov 22, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.75%. Comparing base (3b7d7d4) to head (ef213ce).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2154   +/-   ##
=========================================
  Coverage     70.75%   70.75%           
- Complexity    10008    10010    +2     
=========================================
  Files           842      842           
  Lines         40346    40346           
  Branches       6115     6115           
=========================================
+ Hits          28546    28547    +1     
- Misses         9050     9051    +1     
+ Partials       2750     2748    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@jtduffy jtduffy merged commit 4431da3 into main Nov 22, 2024
111 checks passed
@jtduffy jtduffy deleted the trace-parent-logging branch November 22, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve logging when multiple traceheaders detected
3 participants