Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging when multiple traceheaders detected #2126

Closed
kyrielia opened this issue Nov 4, 2024 · 1 comment · Fixed by #2154
Closed

Improve logging when multiple traceheaders detected #2126

kyrielia opened this issue Nov 4, 2024 · 1 comment · Fixed by #2154
Assignees
Labels
feature request Suggestion for a new product enhancement or change

Comments

@kyrielia
Copy link

kyrielia commented Nov 4, 2024

Is your feature request related to a problem? Please describe.

In 8.10.0, this log line was introduced into the newrelic-agent:
https://github.com/newrelic/newrelic-java-agent/blob/main/newrelic-agent/src/main/java/com/newrelic/agent/tracing/W3CTraceParentParser.java#L25

We have a microservice that has been updated to the latest version of NR agent, where we are now seeing this warning pollute our logs. My impression is that we have always had this multiple traceparent issue, but before it was invisible.

However the log line in its current form is unhelpful. It tells you that there is a problem with multiple traceparents, but the agent does not log anything else to help you triage and locate the source of the traceparents.

Feature Description

It would be useful if:

  • This log line included the list of traceparents.
  • There was easier/better logging to help triage whether a traceparent came from an API request, or was inserted by the agent. At the moment, I'm finding it very difficult to prove one or the other.

Describe Alternatives

Have tried to search the traceparent in New Relic dashboard, but wasn't able to locate it.

Additional context

Add any other context here.

Priority

Really Want

@kyrielia kyrielia added the feature request Suggestion for a new product enhancement or change label Nov 4, 2024
@workato-integration
Copy link

@kyrielia kyrielia changed the title Improve logging when multiple traceheaders detected Improve logging when multiple traceparent headers detected Nov 4, 2024
@workato-integration workato-integration bot changed the title Improve logging when multiple traceparent headers detected Improve logging when multiple traceheaders detected Nov 5, 2024
@jtduffy jtduffy self-assigned this Nov 21, 2024
@github-project-automation github-project-automation bot moved this from Needs Review to Code Complete/Done in Java Engineering Board Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Suggestion for a new product enhancement or change
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants