Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use recordResponseTimeMetric instead recordMetric in NewRelic agent API layer #2132

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

jtduffy
Copy link
Contributor

@jtduffy jtduffy commented Nov 8, 2024

Test run PR of #2128 from @Matzz

com.newrelic.api.agent.NewRelic::recordResponseTimeMetric is calling the wrong method on the metricAggregator instance:

    public static void recordResponseTimeMetric(String name, long millis) {
        getAgent().getMetricAggregator().recordMetric(name, millis);
    }

It seams that 
```
    public static void recordResponseTimeMetric(String name, long millis) {
        getAgent().getMetricAggregator().recordMetric(name, millis);
    }
```
recordResponseTimeMetric calls recordMetric in MetricAggregator instead of recordResponseTimeMetric.
@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.71%. Comparing base (d1111df) to head (4674860).
Report is 9 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2132      +/-   ##
============================================
+ Coverage     70.69%   70.71%   +0.01%     
- Complexity     9983     9985       +2     
============================================
  Files           841      841              
  Lines         40289    40290       +1     
  Branches       6107     6107              
============================================
+ Hits          28484    28492       +8     
+ Misses         9062     9053       -9     
- Partials       2743     2745       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jtduffy jtduffy merged commit 18e4034 into main Nov 8, 2024
137 of 140 checks passed
@jtduffy jtduffy deleted the record-metric-api-fix branch November 8, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants