Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use recordResponseTimeMetric instead recordMetric in NewRelic agent. #2128

Merged
1 commit merged into from
Nov 8, 2024

Conversation

Matzz
Copy link
Contributor

@Matzz Matzz commented Nov 7, 2024

It seams that

    public static void recordResponseTimeMetric(String name, long millis) {
        getAgent().getMetricAggregator().recordMetric(name, millis);
    }

recordResponseTimeMetric calls recordMetric in MetricAggregator instead of recordResponseTimeMetric.

It seams that 
```
    public static void recordResponseTimeMetric(String name, long millis) {
        getAgent().getMetricAggregator().recordMetric(name, millis);
    }
```
recordResponseTimeMetric calls recordMetric in MetricAggregator instead of recordResponseTimeMetric.
@CLAassistant
Copy link

CLAassistant commented Nov 7, 2024

CLA assistant check
All committers have signed the CLA.

@jtduffy jtduffy closed this pull request by merging all changes into newrelic:main in 18e4034 Nov 8, 2024
@Matzz Matzz deleted the patch-1 branch December 4, 2024 22:17
@Matzz
Copy link
Contributor Author

Matzz commented Dec 4, 2024

@jtduffy I just started to wonder if I introduced backward compatibility break here.
As far as I understand when we call MetricAggregator.recordResponseTimeMetric the values are converted from millis to seconds. Is that the same case for recordMetric? What is the difference between recordMetric and recordResponseTimeMetric?
Does changing recordMetric to recordResponseTimeMetric could break some existing charts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants