-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not merge -- infinite tracing compression and batching #1266
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng. Payloads being sent to trace observers will be compressed with `gzip` compression by default and will attempt to send batches of up to 100 spans by default. This replaces the existing default of no compression and no batching. The data is still streaming over HTTP/2 using gRPC but utilizing compression and batching to significantly reduce payload sizes and bytes over the wire, resulting in lower network transfer costs.
…bility metrics to bring implementation in line with agent spec.
Codecov Report
@@ Coverage Diff @@
## main #1266 +/- ##
============================================
+ Coverage 57.95% 57.98% +0.02%
- Complexity 8525 8544 +19
============================================
Files 943 945 +2
Lines 42264 42335 +71
Branches 6150 6157 +7
============================================
+ Hits 24496 24547 +51
- Misses 15357 15373 +16
- Partials 2411 2415 +4
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…high-security NR-106006 fix how user attribute is set in servlet-user from previous PR
…ng. Payloads being sent to trace observers will be compressed with `gzip` compression by default and will attempt to send batches of up to 100 spans by default. This replaces the existing default of no compression and no batching. The data is still streaming over HTTP/2 using gRPC but utilizing compression and batching to significantly reduce payload sizes and bytes over the wire, resulting in lower network transfer costs.
…bility metrics to bring implementation in line with agent spec.
…lic-java-agent into NR-87880-infinite-tracing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge
Original PR: #1146
Overview
This PR adds support for Infinite Tracing payloads to be both compressed and batched by default. The following changes are included as part of this work:
gzip
compression is enabled by default for batching and non-batching configurationsenabled
by default100
spans bundled per batch5s
to fill up the batch before sendingThe span data is still streaming over HTTP/2 using gRPC but utilizing compression and batching will significantly reduce payload sizes and bytes over the wire, resulting in significantly lower network transfer costs for customers.
Testing
All new functionality has been covered with unit tests where possible.
Checks
Are your contributions backwards compatible with relevant frameworks and APIs?
Does your code contain any breaking changes?
Does your code introduce any new dependencies?
testImplementation
dependency for parameterized tests