NR-106006 fix how user attribute is set in servlet-user from previous PR #1265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obenkenobi
changed the title
obenkenobi
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1265 +/- ##
============================================
- Coverage 57.96% 57.95% -0.02%
Complexity 8523 8523
============================================
Files 943 943
Lines 42260 42264 +4
Branches 6150 6150
============================================
- Hits 24494 24492 -2
- Misses 15355 15360 +5
- Partials 2411 2412 +1
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jtduffy
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a problem that is missed in the previous PR for the ticket because GHA was not working so tests did not run. The "user" attribute was changed to a custom attribute but I reverted it to be an agent attribute.