Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregate dimensional metrics #408

Merged
merged 20 commits into from
Sep 25, 2023
Merged

Aggregate dimensional metrics #408

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
6def158
Dimensional metric reporting
tpitale Jan 14, 2022
e6f7014
Read interval_ms from telemetry sdk config for harvest cycle
tpitale Jan 23, 2022
0868dee
Start attempting to use counters with attributes
tpitale Feb 7, 2022
0097a8f
Make note of what I plan to do
tpitale Aug 9, 2022
e839d38
WIP: aggregate them metrics
XiXiaPdx Sep 14, 2023
402f4a8
a start on summary metric
XiXiaPdx Sep 14, 2023
132910f
format
XiXiaPdx Sep 14, 2023
61f1b81
send the metrics, not the useless key
XiXiaPdx Sep 15, 2023
033ca9b
oops, put back
XiXiaPdx Sep 15, 2023
b1e9e79
aggregate count, gauge, summary metrics
XiXiaPdx Sep 15, 2023
67711ae
simplify a bit
XiXiaPdx Sep 15, 2023
d84a290
use correct sdk api
XiXiaPdx Sep 15, 2023
2a95886
fix format for summary metric
XiXiaPdx Sep 15, 2023
739c11e
pattern match for merge metric and clean up unused
XiXiaPdx Sep 18, 2023
9ca187b
test can post dimensional metric
XiXiaPdx Sep 19, 2023
5e39039
reject and log metrics with nil attributes
XiXiaPdx Sep 20, 2023
43204fa
remove hash, just use attributes
XiXiaPdx Sep 20, 2023
95dfb20
update map
XiXiaPdx Sep 20, 2023
ef3239b
calculate interval.ms
XiXiaPdx Sep 21, 2023
b18e6da
remove check for attribute nulls and cleanup
XiXiaPdx Sep 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 9 additions & 15 deletions lib/new_relic/harvest/telemetry_sdk/dimensional_metrics/harvester.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,14 +77,12 @@ defmodule NewRelic.Harvest.TelemetrySdk.DimensionalMetrics.Harvester do
%{type: :count, name: name, value: new_value, attributes: attributes} = metric,
metrics_acc
) do
attributes_hash = :erlang.phash2(attributes)
tpitale marked this conversation as resolved.
Show resolved Hide resolved

case Map.get(metrics_acc, {:count, name, attributes_hash}) do
case Map.get(metrics_acc, {:count, name, attributes}) do
nil ->
Map.put(metrics_acc, {:count, name, attributes_hash}, metric)
Map.put(metrics_acc, {:count, name, attributes}, metric)

%{type: :count, value: current_value} = current_metric ->
Map.put(metrics_acc, {:count, name, attributes_hash}, %{
Map.put(metrics_acc, {:count, name, attributes}, %{
current_metric
| value: current_value + new_value
})
Expand All @@ -95,24 +93,20 @@ defmodule NewRelic.Harvest.TelemetrySdk.DimensionalMetrics.Harvester do
%{type: :gauge, name: name, value: new_value, attributes: attributes} = metric,
metrics_acc
) do
attributes_hash = :erlang.phash2(attributes)

case Map.get(metrics_acc, {:gauge, name, attributes_hash}) do
case Map.get(metrics_acc, {:gauge, name, attributes}) do
nil ->
Map.put(metrics_acc, {:gauge, name, attributes_hash}, metric)
Map.put(metrics_acc, {:gauge, name, attributes}, metric)

%{type: :gauge} = current_metric ->
Map.put(metrics_acc, {:gauge, name, attributes_hash}, %{current_metric | value: new_value})
Map.put(metrics_acc, {:gauge, name, attributes}, %{current_metric | value: new_value})
end
end

defp merge_metric(
%{type: :summary, name: name, value: new_value, attributes: attributes},
metrics_acc
) do
attributes_hash = :erlang.phash2(attributes)

case Map.get(metrics_acc, {:summary, name, attributes_hash}) do
case Map.get(metrics_acc, {:summary, name, attributes}) do
nil ->
new_summary = %{
type: :summary,
Expand All @@ -126,12 +120,12 @@ defmodule NewRelic.Harvest.TelemetrySdk.DimensionalMetrics.Harvester do
attributes: attributes
}

Map.put(metrics_acc, {:summary, name, attributes_hash}, new_summary)
Map.put(metrics_acc, {:summary, name, attributes}, new_summary)

%{type: :summary} = current_metric ->
Map.put(
metrics_acc,
{:summary, name, attributes_hash},
{:summary, name, attributes},
%{current_metric | value: update_summary_value_map(current_metric, new_value)}
)
end
Expand Down