Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregate dimensional metrics #408

Merged
merged 20 commits into from
Sep 25, 2023
Merged

Aggregate dimensional metrics #408

merged 20 commits into from
Sep 25, 2023

Conversation

XiXiaPdx
Copy link
Contributor

@XiXiaPdx XiXiaPdx commented Sep 14, 2023

This is a stab to build off of this PR #376

Looking at the original comments by Vince, I think one missing piece was aggregating the dimensional metrics during the 5 second reporting interval? I took a stab at it.@tpitale , if you have some time, love to hear your thoughts on this. I know @mattbaker is interested in getting it over the finish line.

Also, I think that common block is accurate for count and summary - https://docs.newrelic.com/docs/data-apis/ingest-apis/metric-api/report-metrics-metric-api/#optional-map-attributes.

But for gauge, it appears the interval.ms value isn't required. It probably does no harm 😄 As an aside, the old NR Telemetry SDK specs also show gauge without interval.ms

@CLAassistant
Copy link

CLAassistant commented Sep 14, 2023

CLA assistant check
All committers have signed the CLA.

@tpitale
Copy link
Contributor

tpitale commented Sep 15, 2023

👀

@tpitale
Copy link
Contributor

tpitale commented Sep 15, 2023

I have signed the CLA 👎🏼 I must have done it from my NR laptop 🙃

@XiXiaPdx
Copy link
Contributor Author

I was able to send count and gauge to NR. https://staging.onenr.io/0oqQalyXGj1

But I'm having issues with summary and it is not clear to me why. I started a thread in help-metric

Copy link
Contributor

@tpitale tpitale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, thanks for picking this up!

@XiXiaPdx
Copy link
Contributor Author

confirmed count gauge and summary are all making it to NR. https://staging.onenr.io/0kERzx3KAQr

Copy link
Contributor

@mattbaker mattbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Sort of back tracked on how to handle the nil attribute thing (see comment) but otherwise this looks good to me! I see Tony already gave it the thumbs up.

We should give it a go in some prod systems to see how it goes.

Did you test the memory stuff with large maps in the key? I think that was the only remaining open question

@mattbaker mattbaker merged commit 8bb81d0 into newrelic:master Sep 25, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants