Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Multilingual Reporting of Event Values #575

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

arunshenoy99
Copy link
Member

Proposed changes

Fix the reporting of event values in both English and Brazilian Portuguese for the following events:

  1. Onboarding Step Skipped (moving from internationalized step names to slugs). For example, 'Basic Info' would become 'basic-info,' and similarly, every step now has its own slug that will not be translated.
  2. Onboarding Starter Pages Selected (moving from internationalized page names to slugs). For example, 'About' would become 'about,' and similarly, every Site Page has its own key.

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Goes with: newfold-labs/wp-module-onboarding-data#95

@arunshenoy99 arunshenoy99 added the Code Review The PR is in Code Review label Jun 6, 2024
Copy link
Member

@officiallygod officiallygod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

@officiallygod officiallygod added QA This PR is in QA and removed Code Review The PR is in Code Review labels Jun 13, 2024
@officiallygod officiallygod added Ready to merge The Code Review and QA is done and it can be merged. and removed QA This PR is in QA labels Jun 14, 2024
@officiallygod officiallygod merged commit b1d548b into trunk Jun 14, 2024
4 of 6 checks passed
@officiallygod officiallygod deleted the fix/multilingual-event-values branch June 14, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to merge The Code Review and QA is done and it can be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants