Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keys to site-pages #95

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Conversation

arunshenoy99
Copy link
Member

@arunshenoy99 arunshenoy99 commented Jun 6, 2024

Proposed changes

This adds a new key to the site-pages array, which will be used across languages to identify and report events on the site pages step.

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

This goes with: newfold-labs/wp-module-onboarding#575

@officiallygod officiallygod added QA Ready for QA Ready to merge The PR is Code Reviewed and Tested and can be merged. and removed Code Review Code Review QA Ready for QA labels Jun 13, 2024
@officiallygod officiallygod merged commit 4e4abbf into main Jun 14, 2024
2 of 3 checks passed
@arunshenoy99 arunshenoy99 deleted the fix/multilingual-event-values branch September 11, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to merge The PR is Code Reviewed and Tested and can be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants