PRESS2-1489 Add Cypress Tests for site-logo step #410
Conversation
| const sampleLogoPath = `vendor/newfold-labs/wp-module-onboarding/tests/cypress/fixtures/image.png`; | ||
| const LogoPreviewClass = '.nfd-onboarding-image-uploader--with-text__site_logo__preview'; | ||
| if( | ||
| cy.get('.nfd-onboarding-button--site-gen-next--disabled') |
There was a problem hiding this comment.
This is an assertion, will it have a return value true/false?
There was a problem hiding this comment.
Yes, if the element is not visible, it'll return false.
There was a problem hiding this comment.
We have used this in basic info step also, in earlier onboarding flow.
| .scrollIntoView() | ||
| .should( 'be.visible' ); | ||
| } ); | ||
| }); |
There was a problem hiding this comment.
What would be the else condition? Next is enabled which means Logo is already uploaded.
| .click(); | ||
| cy.url().should('not.contain', currURL); | ||
| cy.go('back'); | ||
| }; |
There was a problem hiding this comment.
Click Back meaning you are in site-detail step and cy.go('back') will take us to site-logo again right? Just checking.
| } ); | ||
| }); | ||
|
|
||
| }); |
There was a problem hiding this comment.
Click on next and verify if its going to social media step or not.
|
|
||
| it( 'Check for the skip button and click', () => { | ||
| SkipButtonCheck('sitgen/step/site-logo'); | ||
| } ); |
There was a problem hiding this comment.
Verifying upon skip, url is not current URL is okay.
We need to also check if it is exactly going to next right step or not. Please verify next expected step url too.
There was a problem hiding this comment.
As I commented on the other PR as well. We are not checking the next page URL as in future the order of pages might change and this will lead to failing of tests. Checking the curr URL is sufficient, I guess whether the current URL changes or not.
PRESS2-1485 Cypress Tests for SiteGen Welcome Step
avneet-raj
added
Ready to merge
No description provided.