PRESS2-1485 Cypress Tests for SiteGen Welcome Step #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sangeetha-nayak
suggested changes
Jan 12, 2024
| .click(); | ||
| cy.wait(2000); | ||
| cy.url().should('not.contain', 'sitegen/step/welcome'); | ||
| } ); |
There was a problem hiding this comment.
Add an assertion to verify if next step is site-detail step or not.
There was a problem hiding this comment.
No, we don't require this. As, in future, if we have the order changes, the test will start to fail. So, this will be sufficient to test that we jump onto the next step.
We have used the same approach in the earlier onboarding flow also.
sangeetha-nayak
approved these changes
Jan 12, 2024
avneet-raj
added
Ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.