Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress api events for site type secondary page #347

Merged
merged 6 commits into from
Nov 7, 2023

Conversation

avneet-raj
Copy link
Contributor

No description provided.

@avneet-raj avneet-raj self-assigned this Oct 31, 2023
@avneet-raj avneet-raj added the WIP PR is a Work in Progress and not ready for review. label Oct 31, 2023
@avneet-raj avneet-raj added Code Review The PR is in Code Review and removed WIP PR is a Work in Progress and not ready for review. labels Oct 31, 2023
Copy link
Contributor

@ajayadav09 ajayadav09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked the assertions on local @avneet-raj will you also be adding the regex pattern for baseUrl in this PR ?

@ajayadav09 ajayadav09 self-requested a review November 6, 2023 13:37
@avneet-raj avneet-raj removed the Code Review The PR is in Code Review label Nov 7, 2023
@avneet-raj avneet-raj merged commit e8b26b2 into trunk Nov 7, 2023
@arunshenoy99 arunshenoy99 deleted the add/Cypress-API-events-sitetype-secondary branch November 7, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants