Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tests events API for top priority #342

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

avneet-raj
Copy link
Contributor

Adding cypress tests for events API for the top priority page also some code enhancements by calling a single function inside the EventsAPI file as it is similar for get_started_experience pages as well.

@avneet-raj avneet-raj self-assigned this Oct 25, 2023
@avneet-raj avneet-raj added the Code Review The PR is in Code Review label Oct 25, 2023
Comment on lines 2 to +4
'get_started_experience' : 'http://localhost:8882/index.php?rest_route=%2Fnewfold-onboarding%2Fv1%2Fevents%2Fbatch&flow=wp-setup&_locale=user',
'get_started_experience_ecomm' : 'http://localhost:8882/index.php?rest_route=%2Fnewfold-onboarding%2Fv1%2Fevents%2Fbatch&flow=ecommerce&_locale=user'
'get_started_experience_ecomm' : 'http://localhost:8882/index.php?rest_route=%2Fnewfold-onboarding%2Fv1%2Fevents%2Fbatch&flow=ecommerce&_locale=user',
'top_priority' : 'http://localhost:8882/index.php?rest_route=%2Fnewfold-onboarding%2Fv1%2Fevents%2Fbatch&flow=wp-setup&_locale=user'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need to create a regex for these.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not able to update it here, but #347 PR has all the changes with regex.

@avneet-raj avneet-raj merged commit 4c9d145 into trunk Nov 7, 2023
@arunshenoy99 arunshenoy99 deleted the add/cypress-API-events-Top-Priority branch November 7, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Review The PR is in Code Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants