Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fallbacks for signup date #194

Merged
merged 1 commit into from
Mar 13, 2023
Merged

Add fallbacks for signup date #194

merged 1 commit into from
Mar 13, 2023

Conversation

arunshenoy99
Copy link
Member

  1. Fallback to the install_date set by the plugin when signup date is not available from customer data.
  2. Move the hard-coded signup date threshold to a brand specific configuration.
  3. Improve ModuleController code to be efficient.

@arunshenoy99 arunshenoy99 merged commit 3f27377 into add/PRESS2-682-support-crazydomains Mar 13, 2023
@arunshenoy99 arunshenoy99 deleted the enhance/PRESS2-674-signup-date-fallback branch March 13, 2023 09:15
@arunshenoy99 arunshenoy99 restored the enhance/PRESS2-674-signup-date-fallback branch March 28, 2023 07:52
@arunshenoy99 arunshenoy99 deleted the enhance/PRESS2-674-signup-date-fallback branch March 28, 2023 08:36
@abhijitb abhijitb linked an issue Apr 24, 2023 that may be closed by this pull request
MySQL update query run on all front-end page loads #216
Closed
@arunshenoy99 arunshenoy99 mentioned this pull request May 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@officiallygod officiallygod officiallygod approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MySQL update query run on all front-end page loads
2 participants
@arunshenoy99 @officiallygod