Remove unnecessary redirect transient update #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhijitb
added
Ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The redirect transient was updating on every page load even after the fix we did in 1.4.0 because the
enable_redirectcode that we removed when improving the efficiency ofModuleControllersolved the transient update issue only when a site met the onboarding criteria.This PR removes the unnecessary
disable_redirectcall that runs whenever a site does not meet the criteria for Onboarding, in this case the module disables itself, preventing a login redirect, and we do not need to manually set a transient (this is the edge case we need to test whenever performing QA).