Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRESS2 335 Fix the blank space before theme skeleton spins up #104

Conversation

officiallygod
Copy link
Member

No description provided.

@officiallygod officiallygod added the WIP PR is a Work in Progress and not ready for review. label Nov 10, 2022
Copy link
Member

@arunshenoy99 arunshenoy99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on #102 (review) might affect this as well please do check

@officiallygod officiallygod removed the WIP PR is a Work in Progress and not ready for review. label Nov 15, 2022
Copy link
Member

@arunshenoy99 arunshenoy99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The skeleton state looks really really good now @officiallygod, just a few things to make it better.

includes/Data/Data.php Outdated Show resolved Hide resolved
includes/Data/Patterns.php Outdated Show resolved Hide resolved
src/OnboardingSPA/components/LivePreviewSkeleton/index.js Outdated Show resolved Hide resolved
includes/Data/Data.php Outdated Show resolved Hide resolved
includes/Data/Data.php Outdated Show resolved Hide resolved
includes/Data/Data.php Outdated Show resolved Hide resolved
src/OnboardingSPA/pages/Steps/DesignHomepageMenu/index.js Outdated Show resolved Hide resolved
Copy link
Member

@arunshenoy99 arunshenoy99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it is related to this story but when I select a color and move onto typography I get the state maintained as expected but on a hard refresh of
the step I lose the color state, attaching screenshots of before and after a refresh
Screenshot 2022-11-28 at 2 19 44 PM
Screenshot 2022-11-28 at 2 21 06 PM

includes/Data/Patterns.php Outdated Show resolved Hide resolved
includes/Data/Patterns.php Outdated Show resolved Hide resolved
includes/Data/Themes.php Outdated Show resolved Hide resolved
src/OnboardingSPA/pages/Steps/DesignHomepageMenu/index.js Outdated Show resolved Hide resolved
@arunshenoy99 arunshenoy99 merged commit e9eea11 into release/v1.0.0 Nov 29, 2022
@arunshenoy99 arunshenoy99 deleted the PRESS2-335-Fix-the-Blank-Space-before-Theme-Skeleton-spins-up branch November 29, 2022 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants