Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRESS2 331 Maintain State for colors and typography steps #102

Conversation

officiallygod
Copy link
Member

No description provided.

@officiallygod officiallygod added the WIP PR is a Work in Progress and not ready for review. label Oct 28, 2022
@officiallygod officiallygod changed the title PRESS 2 331 Maintain State for colors and typography steps PRESS2 331 Maintain State for colors and typography steps Oct 28, 2022
@officiallygod officiallygod removed the WIP PR is a Work in Progress and not ready for review. label Oct 31, 2022
Copy link
Member

@arunshenoy99 arunshenoy99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed with @officiallygod for a common parent component across all steps that sets up the preview state similar to DesignStateHandler. This will also affect the skeleton loader PR.

includes/Data/Options.php Outdated Show resolved Hide resolved
includes/RestApi/Themes/ThemeVariationsController.php Outdated Show resolved Hide resolved
includes/RestApi/Themes/ThemeVariationsController.php Outdated Show resolved Hide resolved
src/OnboardingSPA/components/GlobalStyleParent/index.js Outdated Show resolved Hide resolved
src/OnboardingSPA/components/GlobalStyleParent/index.js Outdated Show resolved Hide resolved
src/OnboardingSPA/components/GlobalStyleParent/index.js Outdated Show resolved Hide resolved
src/OnboardingSPA/components/GlobalStyleParent/index.js Outdated Show resolved Hide resolved
Copy link
Member

@arunshenoy99 arunshenoy99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! A couple minor refactors and let's run formatters on the PHP and JS files

@officiallygod officiallygod merged commit 2563768 into release/v1.0.0 Nov 22, 2022
@arunshenoy99 arunshenoy99 deleted the PRESS-2-331-Maintain-State-for-Colors-and-Typography-Steps branch November 22, 2022 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants