Skip to content

Minor dark mode fixes and slot filled footers #1045

Minor dark mode fixes and slot filled footers

Minor dark mode fixes and slot filled footers #1045

Triggered via pull request November 29, 2023 08:47
Status Success
Total duration 38s
Artifacts

lint-check-spa.yml

on: pull_request
Run Lint Checks
27s
Run Lint Checks
Fit to window
Zoom out
Zoom in

Annotations

8 warnings
Run Lint Checks: src/OnboardingSPA/components/NewfoldInterfaceSkeleton/SiteBuild/index.js#L104
React Hook useSelect has an unnecessary dependency: 'location.pathname'. Either exclude it or remove the dependency array
Run Lint Checks: src/OnboardingSPA/components/NewfoldInterfaceSkeleton/SiteBuild/index.js#L367
React Hook useEffect has a missing dependency: 'trackChapters'. Either include it or remove the dependency array
Run Lint Checks: src/OnboardingSPA/components/NewfoldInterfaceSkeleton/SiteBuild/index.js#L408
React Hook useEffect has a missing dependency: 'pluginInstallHash'. Either include it or remove the dependency array
Run Lint Checks: src/OnboardingSPA/components/NewfoldInterfaceSkeleton/SiteBuild/index.js#L414
React Hook useEffect has missing dependencies: 'brandConfig?.prioritization' and 'prioritizeFlow'. Either include them or remove the dependency array
Run Lint Checks: src/OnboardingSPA/components/NewfoldInterfaceSkeleton/SiteBuild/index.js#L424
React Hook useEffect has missing dependencies: 'handleConditionalDesignStepsRoutes', 'handlePreviousStepTracking', and 'syncStoreToDB'. Either include them or remove the dependency array
Run Lint Checks: src/OnboardingSPA/components/NewfoldInterfaceSkeleton/SiteGen/index.js#L114
React Hook useEffect has missing dependencies: 'generateSiteGenData', 'handlePreviousStepTracking', and 'syncStoreToDB'. Either include them or remove the dependency array
Run Lint Checks: src/OnboardingSPA/steps/SiteGen/Experience/index.js#L35
React Hook useEffect contains a call to 'setSelection'. Without a list of dependencies, this can lead to an infinite chain of updates. To fix this, pass [setIsHeaderEnabled, setSidebarActiveView, setHeaderActiveView, setDrawerActiveView, currentData.sitegen.experience.level] as a second argument to the useEffect Hook
Run Lint Checks: src/OnboardingSPA/steps/SiteGen/SiteDetails/index.js#L41
React Hook useEffect has missing dependencies: 'currentData.sitegen.siteDetails.prompt', 'setDrawerActiveView', 'setHeaderActiveView', 'setIsHeaderEnabled', and 'setSidebarActiveView'. Either include them or remove the dependency array