Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor dark mode fixes and slot filled footers #376

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

arunshenoy99
Copy link
Member

This PR makes minor fixes to the positioning and animation of the dark mode button. Also, it introduces slot-filled footers, this should greatly simplify the implementation of various step-specific footer layouts in the new v2 Figma.

@arunshenoy99 arunshenoy99 added the Code Review The PR is in Code Review label Nov 29, 2023
Copy link
Member

@officiallygod officiallygod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arunshenoy99 arunshenoy99 merged commit 241e85a into enhance/ai-onboarding Nov 30, 2023
2 checks passed
@arunshenoy99 arunshenoy99 deleted the enhance/dark-mode-logic branch November 30, 2023 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Review The PR is in Code Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants