Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRESS0-1625-P3 incident fix #333

Merged
merged 2 commits into from
Jun 27, 2024
Merged

PRESS0-1625-P3 incident fix #333

merged 2 commits into from
Jun 27, 2024

Conversation

aratidgr8
Copy link
Contributor

@aratidgr8 aratidgr8 commented Jun 27, 2024

Proposed changes

https://jira.newfold.com/browse/PRESS0-1625

  • When hasYithExtended is set to true it means Customer has purchased Ecommerce Plan and we should display YITH plugins on store page.
  • When hasEcomdash is set to true display it means Customer has purchased Ecommerce Plus Plan and we should display EcomDash plugin alongwith other YITH plugins on store page.
  • When hasYithExtended is set to false it means Customer has not purchased Ecommerce Plan and we should show buy Ecom Addon screen on store page.

Ecommerce Basic

Ecommerce-basic

Ecommerce Plus

Ecommerce-Plus

Non-Ecommerce

Non-Ecommerce

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@aratidgr8 aratidgr8 requested a review from diwanshuster June 27, 2024 14:02
diwanshuster
diwanshuster previously approved these changes Jun 27, 2024
@chrisdavidmiles
Copy link

Tested for:

  • If a customer doesn't have the ecommerce addon we should be showing an ad for it
  • If a customer does have the basic level we should show those items (yith extended plugins)
  • If a customer does have the plus level we should show those items (yith extended plugins + ecomdash)

Looks good to me. ✅

@aratidgr8 aratidgr8 merged commit 3478b6e into trunk Jun 27, 2024
3 of 5 checks passed
@aratidgr8 aratidgr8 deleted the PRESS0-1625 branch June 27, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants