Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ecommerce version bump to 1.3.35 #1144

Merged
merged 4 commits into from
Jul 1, 2024

Conversation

aratidgr8
Copy link
Contributor

@aratidgr8 aratidgr8 commented Jun 26, 2024

Proposed changes

Bug Fix:

Tech Debt:

  • GitHub Issue : Updated the DB variable name fromshowMigrationStep tonfd_show_migration_step as per NewFold coding standards.
  • Cypress tests improvised - Implemented the testIsolation flag so each test is expected to be more independent, and combined tests that were not independent to run in the same it

Feature Requests:

  • PRESS0-631 | Dismiss woo notice

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@aratidgr8 aratidgr8 requested review from circlecube and wpalani June 26, 2024 12:07
Copy link

cypress bot commented Jun 26, 2024

1 flaky test on run #9011 ↗︎

0 387 59 0 Flakiness 1

Details:

Resolve composer lock file conflicts
Project: Bluehost Brand Plugin Commit: 3b150f98e8
Status: Passed Duration: 25:46 💡
Started: Jul 1, 2024 4:00 PM Ended: Jul 1, 2024 4:25 PM
Flakiness  vendor/newfold-labs/wp-module-ecommerce/tests/cypress/integration/Home/homePageWithWoo.cy.js • 1 flaky test

View Output Video

Test Artifacts
e-commerce Home Page - When WooCommerce is installed > Verify next steps "Add your store info" Screenshots Video

Review all test suite changes for PR #1144 ↗︎

Copy link

cypress bot commented Jun 26, 2024

1 flaky test on run #8931 ↗︎

0 387 59 0 Flakiness 1

Details:

Merge d9ff83e into 2c698f6...
Project: Bluehost Brand Plugin Commit: f027ac175e ℹ️
Status: Passed Duration: 26:43 💡
Started: Jun 26, 2024 12:12 PM Ended: Jun 26, 2024 12:38 PM
Flakiness  vendor/newfold-labs/wp-module-ecommerce/tests/cypress/integration/Home/homePageWithWoo.cy.js • 1 flaky test

View Output Video

Test Artifacts
e-commerce Home Page - When WooCommerce is installed > Verify next steps "Add your store info" Test Replay Screenshots Video

Review all test suite changes for PR #1144 ↗︎

@aratidgr8 aratidgr8 requested a review from wpscholar June 26, 2024 13:09
@wpscholar
Copy link
Member

@aratidgr8 Can you address the current conflicts, please? Thank!

@aratidgr8 aratidgr8 changed the title Ecommerce version bump to 1.3.34 Ecommerce version bump to 1.3.35 Jun 27, 2024
@aratidgr8
Copy link
Contributor Author

@wpscholar Conflicts have been resolved. Please help me with review. Thanks.

@circlecube
Copy link
Member

It looks like all the workflows are failing. From the workflows I see the following:

Lock file errors

  • The lock file is not up to date with the latest changes in composer.json, it is recommended that you run composer update or composer update <package name>.

@aratidgr8
Copy link
Contributor Author

@circlecube Lock file conflicts are resolved. Thanks!

@circlecube
Copy link
Member

Thanks @aratidgr8

@circlecube circlecube merged commit 2541fad into develop Jul 1, 2024
3 checks passed
@circlecube circlecube deleted the update/ecommerce-release-bump-1.3.34 branch July 1, 2024 16:41
@circlecube circlecube added this to the July 10 Release milestone Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants